Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ease opening photos picker in album content view #2772

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 22, 2025

This means that we can drop the UploadPicker for this view.

I also added logger in AlbumRoot.php, which imply touching a lot of files as it is manually instanced.

@artonge artonge added bug Something isn't working 3. to review Waiting for reviews php PHP related ticket javascript Javascript related ticket labels Jan 22, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 22, 2025
@artonge artonge requested a review from skjnldsv January 22, 2025 16:25
@artonge artonge self-assigned this Jan 22, 2025
@artonge artonge force-pushed the artonge/feat/ease_opening_photo_picker branch 2 times, most recently from c47677c to 065d2d3 Compare January 22, 2025 17:58
@artonge artonge requested a review from susnux January 27, 2025 16:27
src/views/AlbumContent.vue Outdated Show resolved Hide resolved
@artonge artonge force-pushed the artonge/feat/ease_opening_photo_picker branch 2 times, most recently from 611f530 to 1d1653d Compare January 28, 2025 12:40
@artonge artonge requested a review from susnux January 28, 2025 15:00
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/ease_opening_photo_picker branch from 1d1653d to 53fa229 Compare January 28, 2025 15:07
@artonge
Copy link
Collaborator Author

artonge commented Jan 28, 2025

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 295c124 into master Jan 29, 2025
46 checks passed
@artonge artonge deleted the artonge/feat/ease_opening_photo_picker branch January 29, 2025 13:10
@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable31

@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 29, 2025
@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable29

@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable28

@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport to stable26

@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport 3445813 to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 29, 2025
@artonge
Copy link
Collaborator Author

artonge commented Jan 29, 2025

/backport 3445813 to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants