Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One page picker #46

Closed
wants to merge 46 commits into from
Closed

One page picker #46

wants to merge 46 commits into from

Conversation

Thatoo
Copy link
Contributor

@Thatoo Thatoo commented Jul 27, 2024

Thanks to @nextcloud/dialogs v5.3.5 and @nextcloud/vue v8.15.0 it is now possible to build picker window with several button having each one its own action.
This is why i propose to make the choice between read and write directly on the front page to gain one step.
I also merged (and adapt) my work from #38 to give the option to have either one window that open files or one window (depending on an url parameter : ?option=Clipboard) that copy one of the three link (read, write or internal) into the Clipboard.

Everything is working as expected!

I just can't make icons to be displayed. Colors of button are just for trying.

@Thatoo
Copy link
Contributor Author

Thatoo commented Jul 28, 2024

I ask about this icon not displaying issue in here nextcloud-libraries/nextcloud-dialogs#1403 so I'm hopeful it will be solved.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Thatoo
Copy link
Contributor Author

Thatoo commented Aug 20, 2024

screenshot-2024-08-20-13-02-10

it's working now.

I'll cleanup my PR and make a new one. Then only translation will remain.

@Thatoo Thatoo closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant