Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #1074

Merged
merged 3 commits into from
May 6, 2024
Merged

Add SPDX header #1074

merged 3 commits into from
May 6, 2024

Conversation

AndyScherzinger
Copy link
Member

No description provided.

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 2 times, most recently from 7b4e0d5 to 8fa96a1 Compare May 3, 2024 18:07
@AndyScherzinger
Copy link
Member Author

/compile /

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone May 3, 2024
@Pytal
Copy link
Member

Pytal commented May 3, 2024

This changes the app icon slightly and makes it horizontal
image
from the latest material design icons, is this okay with you @jancborchardt ?

jancborchardt
jancborchardt approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, app icon change is totally fine. :)

AndyScherzinger and others added 3 commits May 6, 2024 12:17
@AndyScherzinger
chore: Add SPDX header
8ef6bc6 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(ci): Add reuse check
d52b886 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-command @AndyScherzinger
chore(assets): Recompile assets
3e1701c 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit 7fb38be into master May 6, 2024
42 checks passed
@Pytal Pytal deleted the chore/noid/spdx branch May 6, 2024 16:44
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyScherzinger @Pytal @jancborchardt @nextcloud-command