Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate recommendations #43

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Deduplicate recommendations #43

merged 3 commits into from
Mar 12, 2019

Conversation

ChristophWurst
Copy link
Member

Fixes #24

To test

  • create a new file
  • share it

Before: file shown twice
now: file shown once

@ChristophWurst ChristophWurst added the bug Something isn't working label Mar 11, 2019
@ChristophWurst ChristophWurst self-assigned this Mar 11, 2019
@ChristophWurst ChristophWurst requested a review from rullzer March 11, 2019 17:21
@ChristophWurst
Deduplicate recommendations
bbc07fc 
Fixes #24

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
jancborchardt
jancborchardt approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@ChristophWurst ChristophWurst merged commit 84bbb70 into master Mar 12, 2019
@ChristophWurst ChristophWurst deleted the fix/duplication branch March 12, 2019 11:34
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 12, 2019
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@ChristophWurst ChristophWurst

Labels
bug Something isn't working
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @jancborchardt