Add extra fields for registration and fix exception when email address exists

[Peterede]

I have added some extra fields to the registration form to collect more information about the user, these can be turned on/off in the admin settings. I also fixed an exception that occurs if the email address is already in the database and gets added twice.

[pellaeon]

Please also add unit tests for PHP code as well. (currently this project has no front-end testing code setup)

[pellaeon]

Taiwan is not a province of China.

[pellaeon]

Also, please fix the broken existing tests because of your changes.

[Peterede]

When I try and run the tests I get the following error:
~/work/registration$ vendor/phpunit/phpunit/phpunit -c tests/phpunit.xml
PHP Warning: require_once(/home/petere/work/registration/tests/../../../tests/bootstrap.php): failed to open stream: No such file or directory in /home/petere/work/registration/tests/autoloader.php on line 12
PHP Fatal error: require_once(): Failed opening required '/home/petere/work/registration/tests/../../../tests/bootstrap.php' (include_path='.:/usr/share/php') in /home/petere/work/registration/tests/autoloader.php on line 12

[Peterede]

I have fixed another issue where the validation of the email fails because the user is already registered, the login link shows the html as text instead of a link to go to the login page.

[pellaeon]

@Peterede Seems that you don't have a full Nextcloud instance for testing (currently it is required). In order to run the test, you need to run phpunit from the registration directory that resides in a working Nextcloud instance's apps/ directory.
The tests will modify the database but will revert any changes in the clean up phase, so I suggest you still use a test (non-production) Nextcloud instance.

[pellaeon]

Could you also fix the styles of the create account form so that it looks the same as before? I would prefer the fields are not separated.
Before:

After:

• Continuous input fields
• Icons are shifted (the person and eye icon)
• Add icons for new fields so that the design looks consistent

[Peterede]

I have fixed the issues except for the icons on the new fields, I will work on this

[Peterede]

All changes have been made now

[pellaeon]

Sorry, but there are a few more problems that I found out:

1. please use meaningful icons for each field, instead just putting contacts-dark.svg everywhere
2. contacts-dark.svg doesn't exist in Nextcloud's master, this will cause error when rendering the form, please choose the icons that exist in both latest Nextcloud and ownCloud
3. the timezone selection is empty on Nextcloud master
4. please move the fields that have a title (country, language, timezone) to the bottom, because they cannot be combined with other fields. (keep all combined fields together at the top)
   

[Peterede]

1. For some fields there are no meaningful icons available, the nextcloud personal settings uses this icon for multiple fields so I used that as reference.
2. contacts-dark.svg is in /core/img/places/contacts-dark.svg on nextcloud master
3. I have added the moment-timezone-with-data.js file to the app
4. I have moved the lists to the bottom so that the input fields are grouped

[pellaeon]

2. I'm sorry, but I can't find it there: https://github.com/nextcloud/server/tree/master/core/img/places
   Maybe it's related to theming, do you have theming enabled? I don't. There seems to be an issue: NC14: core/img/places/contacts-dark.svg missing server#10443

[pellaeon]

Also, moment-timezone-with-data.js is a 190KB file, could you make it load only when the timezone field is enabled?

[Peterede]

In my checkout of master the file is located in core/img/places but if I download the source from github or view it in the web browser the file is not there. The latest commit shows the file was deleted nextcloud/server@29ff7ef
I replaced contacts-dark.svg with social.svg which is the same icon

[thoka]

I would find this patch very usefull. What has to be done to merge it ?

[nickvergessen]

I would find this patch very usefull. What has to be done to merge it ?

Due to the number of conflicts I guess it has to be redone