fixup! Cleanup tags and Share component

nextcloud · Aug 1, 2022 · 016c90e · 016c90e
1 parent b954f25
commit 016c90e
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 37 deletions.
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
@@ -1112,12 +1112,6 @@
       <code>getUniqueStorages</code>
     </UndefinedMethod>
   </file>
-  <file src="apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php">
-    <InvalidArgument occurrences="2">
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-    </InvalidArgument>
-  </file>
   <file src="apps/files_external/lib/Lib/Backend/Backend.php">
     <InvalidReturnType occurrences="1">
       <code>self</code>
@@ -1294,16 +1288,6 @@
       <code>$_</code>
     </UndefinedVariable>
   </file>
-  <file src="apps/files_sharing/lib/AppInfo/Application.php">
-    <InvalidArgument occurrences="6">
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-    </InvalidArgument>
-  </file>
   <file src="apps/files_sharing/lib/Cache.php">
     <FalsableReturnStatement occurrences="1">
       <code>false</code>
@@ -1924,17 +1908,7 @@
     </UndefinedInterfaceMethod>
   </file>
   <file src="core/Application.php">
-    <InvalidArgument occurrences="9">
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
-    </InvalidArgument>
+    <InvalidArgument occurrences="8"/>
   </file>
   <file src="core/BackgroundJobs/BackgroundCleanupUpdaterBackupsJob.php">
     <ParamNameMismatch occurrences="1">
@@ -2141,10 +2115,8 @@
       <code>getAppsNeedingUpgrade</code>
       <code>getIncompatibleApps</code>
     </InternalMethod>
-    <InvalidArgument occurrences="3">
+    <InvalidArgument occurrences="1">
       <code>$restrictions</code>
-      <code>addServiceListener</code>
-      <code>addServiceListener</code>
     </InvalidArgument>
     <RedundantCondition occurrences="1">
       <code>((array)$request-&gt;getParam('appid')) !== ''</code>

diff --git a/lib/private/Authentication/Listeners/LoginFailedListener.php b/lib/private/Authentication/Listeners/LoginFailedListener.php
@@ -34,9 +34,6 @@
 use OCP\IUserManager;
 use OCP\Util;
 
-/**
- * @template-implements IEventListener<\OC\Authentication\Events\LoginFailed>
- */
 class LoginFailedListener implements IEventListener {
 
 	/** @var IEventDispatcher */

diff --git a/lib/private/Authentication/Listeners/UserLoggedInListener.php b/lib/private/Authentication/Listeners/UserLoggedInListener.php
@@ -31,9 +31,6 @@
 use OCP\EventDispatcher\IEventListener;
 use OCP\User\Events\PostLoginEvent;
 
-/**
- * @template-implements IEventListener<\OCP\User\Events\PostLoginEvent>
- */
 class UserLoggedInListener implements IEventListener {
 
 	/** @var Manager */

diff --git a/lib/public/EventDispatcher/IEventDispatcher.php b/lib/public/EventDispatcher/IEventDispatcher.php
@@ -62,7 +62,7 @@ public function removeListener(string $eventName, callable $listener): void;
 	 * @param string $eventName preferably the fully-qualified class name of the Event sub class to listen for
 	 * @psalm-param string|class-string<T> $eventName preferably the fully-qualified class name of the Event sub class to listen for
 	 * @param string $className fully qualified class name (or ::class notation) of a \OCP\EventDispatcher\IEventListener that can be built by the DI container
-	 * @psalm-param class-string<\OCP\EventDispatcher\IEventListener<T>> $className fully qualified class name that can be built by the DI container
+	 * @psalm-param class-string<\OCP\EventDispatcher\IEventListener> $className fully qualified class name that can be built by the DI container
 	 * @param int $priority The higher this value, the earlier an event
 	 *                      listener will be triggered in the chain (defaults to 0)
 	 *