Merge pull request #42811 from nextcloud/app-command-load-non-fatal

make failure to load app commands non-fatal
nextcloud · Feb 2, 2024 · 20aa86f · 20aa86f
2 parents 6de23a3 + 860caa0
commit 20aa86f
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/private/Console/Application.php b/lib/private/Console/Application.php
@@ -121,7 +121,14 @@ public function loadCommands(
 						// load commands using info.xml
 						$info = $appManager->getAppInfo($app);
 						if (isset($info['commands'])) {
-							$this->loadCommandsFromInfoXml($info['commands']);
+							try {
+								$this->loadCommandsFromInfoXml($info['commands']);
+							} catch (\Throwable $e) {
+								$output->writeln("<error>" . $e->getMessage() . "</error>");
+								$this->logger->error($e->getMessage(), [
+									'exception' => $e,
+								]);
+							}
 						}
 						// load from register_command.php
 						\OC_App::registerAutoloading($app, $appPath);