fix(files_sharing): tab shares title and creation sort

Signed-off-by: Law larre@umich.edu
nextcloud · Feb 23, 2024 · 2aa2822 · 2aa2822
1 parent 2cb7297
commit 2aa2822
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/apps/files_sharing/src/views/SharingTab.vue b/apps/files_sharing/src/views/SharingTab.vue
@@ -275,24 +275,25 @@ export default {
 		 * @param {object} share the share ocs api request data
 		 * @param {object} share.data the request data
 		 */
-        processShares({ data }) {
-            if (data.ocs && data.ocs.data && data.ocs.data.length > 0) {
-                // create Share objects and sort by title in alphabetical order and then by creation time
-                const shares = data.ocs.data
-                .map(share => new Share(share))
-                .sort((a, b) => {
-                    if (a.title < b.title) return -1
-                    if (a.title > b.title) return 1
-                    return b.createdTime - a.createdTime
-                })
-
-                this.linkShares = shares.filter(share => share.type === this.SHARE_TYPES.SHARE_TYPE_LINK || share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL)
-                this.shares = shares.filter(share => share.type !== this.SHARE_TYPES.SHARE_TYPE_LINK && share.type !== this.SHARE_TYPES.SHARE_TYPE_EMAIL)
-
-                console.debug('Processed', this.linkShares.length, 'link share(s)')
-                console.debug('Processed', this.shares.length, 'share(s)')
-            }
-        },
+		processShares({ data }) {
+			if (data.ocs && data.ocs.data && data.ocs.data.length > 0) {
+				// create Share objects and sort by title in alphabetical order and then by creation time
+				const shares = data.ocs.data
+					.map(share => new Share(share))
+					.sort((a, b) => {
+						const localCompare = a.title.localeCompare(b.title)
+						if (localCompare !== 0) {
+							return localCompare
+						}
+						return b.createdTime - a.createdTime
+					})
+				this.linkShares = shares.filter(share => share.type === this.SHARE_TYPES.SHARE_TYPE_LINK || share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL)
+				this.shares = shares.filter(share => share.type !== this.SHARE_TYPES.SHARE_TYPE_LINK && share.type !== this.SHARE_TYPES.SHARE_TYPE_EMAIL)
+
+				console.debug('Processed', this.linkShares.length, 'link share(s)')
+				console.debug('Processed', this.shares.length, 'share(s)')
+			}
+		},
 
 		/**
 		 * Process the sharedWithMe share data