Theming: Fix tests for favicon containing multiple sizes

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Sep 23, 2017 · 4c5b87b · 4c5b87b
1 parent 4fa99a7
commit 4c5b87b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/apps/theming/lib/IconBuilder.php b/apps/theming/lib/IconBuilder.php
@@ -53,6 +53,9 @@ public function __construct(
 	 * @return string|false image blob
 	 */
 	public function getFavicon($app) {
+		if (!$this->themingDefaults->shouldReplaceIcons()) {
+			return false;
+		}
 		try {
 			$favicon = new Imagick();
 			$favicon->setFormat("ico");

diff --git a/apps/theming/tests/IconBuilderTest.php b/apps/theming/tests/IconBuilderTest.php
@@ -151,12 +151,15 @@ public function testGetFavicon($app, $color, $file) {
 			->willReturn($color);
 
 		$expectedIcon = new \Imagick(realpath(dirname(__FILE__)). "/data/" . $file);
+		$actualIcon = $this->iconBuilder->getFavicon($app);
+
 		$icon = new \Imagick();
-		$icon->readImageBlob($this->iconBuilder->getFavicon($app));
+		$icon->setFormat('ico');
+		$icon->readImageBlob($actualIcon);
 
 		$this->assertEquals(true, $icon->valid());
-		$this->assertEquals(32, $icon->getImageWidth());
-		$this->assertEquals(32, $icon->getImageHeight());
+		$this->assertEquals(128, $icon->getImageWidth());
+		$this->assertEquals(128, $icon->getImageHeight());
 		$icon->destroy();
 		$expectedIcon->destroy();
 		// FIXME: We may need some comparison of the generated and the test images