Skip to content

Commit

Permalink
fix(OC_Template.php): ensure we throw all errors
Browse files Browse the repository at this point in the history
In one branch of the try/catch combination, in one specific path no error was thrown at all, thus the user ended up with a 500 error page online but absolutely no error anyway in the logs.

Signed-off-by: Bram <cortex@worlddomination.be>
  • Loading branch information
Psycojoker authored Oct 4, 2023
1 parent cf6e9a1 commit 83b646b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/private/legacy/OC_Template.php
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ public static function printExceptionErrorPage($exception, $statusCode = 503) {
print("The server encountered an internal error and was unable to complete your request.\n");
print("Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report.\n");
print("More details can be found in the server log.\n");

// and then throw it again to log it at least to the web server error log
throw $e;
}
die();
}
Expand Down

0 comments on commit 83b646b

Please sign in to comment.