Merge pull request #44869 from nextcloud/fix/systemtags-input-label

fix(systemtags): Use built-in input label to satisfy a11y check of NcSelect
nextcloud · Apr 17, 2024 · a86c113 · a86c113
2 parents 4988f0d + 07525af
commit a86c113
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/apps/systemtags/src/components/SystemTags.vue b/apps/systemtags/src/components/SystemTags.vue
@@ -26,9 +26,8 @@
 			:name="t('systemtags', 'Loading collaborative tags …')"
 			:size="32" />
 		<template v-else>
-			<label for="system-tags-input">{{ t('systemtags', 'Search or create collaborative tags') }}</label>
 			<NcSelectTags class="system-tags__select"
-				input-id="system-tags-input"
+				:input-label="t('systemtags', 'Search or create collaborative tags')"
 				:placeholder="t('systemtags', 'Collaborative tags …')"
 				:options="sortedTags"
 				:value="selectedTags"
@@ -224,10 +223,7 @@ export default Vue.extend({
 	display: flex;
 	flex-direction: column;
 
-	label[for="system-tags-input"] {
-		margin-bottom: 2px;
-	}
-
+	// Fix issue with AppSidebar styles overwriting NcSelect styles
 	&__select {
 		width: 100%;
 		:deep {

diff --git a/dist/files-sidebar.js b/dist/files-sidebar.js
diff --git a/dist/files-sidebar.js.map b/dist/files-sidebar.js.map