fixup! fix imigration type hints

nextcloud · Feb 20, 2023 · acf9c4a · acf9c4a
1 parent 6e9e6a0
commit acf9c4a
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 17 deletions.
diff --git a/core/Command/Db/Migrations/GenerateCommand.php b/core/Command/Db/Migrations/GenerateCommand.php
@@ -77,17 +77,17 @@ class {{classname}} extends SimpleMigrationStep {
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 */
 	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
 	}
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 * @return null|ISchemaWrapper
 	 */
@@ -97,8 +97,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 */
 	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {

diff --git a/lib/public/Migration/IMigrationStep.php b/lib/public/Migration/IMigrationStep.php
@@ -35,15 +35,15 @@
  */
 interface IMigrationStep {
 	/**
-	 * Human readable name of the migration step
+	 * Human-readable name of the migration step
 	 *
 	 * @return string
 	 * @since 14.0.0
 	 */
 	public function name(): string;
 
 	/**
-	 * Human readable description of the migration steps
+	 * Human-readable description of the migration steps
 	 *
 	 * @return string
 	 * @since 14.0.0
@@ -52,17 +52,17 @@ public function description(): string;
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 * @since 13.0.0
 	 */
 	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options);
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 * @return null|ISchemaWrapper
 	 * @since 13.0.0
@@ -71,8 +71,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @psalm-param Closure $schemaClosure
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
 	 * @param array $options
 	 * @since 13.0.0
 	 */

diff --git a/lib/public/Migration/SimpleMigrationStep.php b/lib/public/Migration/SimpleMigrationStep.php
@@ -56,15 +56,22 @@ public function description(): string {
 	}
 
 	/**
-	 * {@inheritDoc}
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
+	 * @param array $options
 	 *
 	 * @since 13.0.0
 	 */
 	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
 	}
 
 	/**
-	 * {@inheritDoc}
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
+	 * @param array $options
+	 * @return null|ISchemaWrapper
 	 *
 	 * @since 13.0.0
 	 */
@@ -73,7 +80,10 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 	}
 
 	/**
-	 * {@inheritDoc}
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure
+	 * @psalm-param Closure(): ISchemaWrapper $schemaClosure
+	 * @param array $options
 	 *
 	 * @since 13.0.0
 	 */