Merge pull request #46567 from nextcloud/tests/cleanupremotestoragest…

…est-named-parameters move share tests await from positional parameters
nextcloud · Jul 18, 2024 · b64f334 · b64f334
2 parents 9cd2e5b + 7046aac
commit b64f334
Showing 1 changed file with 22 additions and 22 deletions.
diff --git a/apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php b/apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php
@@ -54,48 +54,48 @@ protected function setUp(): void {
 
 		$storageQuery = \OC::$server->getDatabaseConnection()->getQueryBuilder();
 		$storageQuery->insert('storages')
-			->setValue('id', '?');
+			->setValue('id', $storageQuery->createParameter('id'));
 
 		$shareExternalQuery = \OC::$server->getDatabaseConnection()->getQueryBuilder();
 		$shareExternalQuery->insert('share_external')
-			->setValue('share_token', '?')
-			->setValue('remote', '?')
-			->setValue('name', '?')
-			->setValue('owner', '?')
-			->setValue('user', '?')
-			->setValue('mountpoint', '?')
-			->setValue('mountpoint_hash', '?');
+			->setValue('share_token', $shareExternalQuery->createParameter('share_token'))
+			->setValue('remote', $shareExternalQuery->createParameter('remote'))
+			->setValue('name', $shareExternalQuery->createParameter('name'))
+			->setValue('owner', $shareExternalQuery->createParameter('owner'))
+			->setValue('user', $shareExternalQuery->createParameter('user'))
+			->setValue('mountpoint', $shareExternalQuery->createParameter('mountpoint'))
+			->setValue('mountpoint_hash', $shareExternalQuery->createParameter('mountpoint_hash'));
 
 		$filesQuery = \OC::$server->getDatabaseConnection()->getQueryBuilder();
 		$filesQuery->insert('filecache')
-			->setValue('storage', '?')
-			->setValue('path', '?')
-			->setValue('path_hash', '?');
+			->setValue('storage', $filesQuery->createParameter('storage'))
+			->setValue('path', $filesQuery->createParameter('path'))
+			->setValue('path_hash', $filesQuery->createParameter('path_hash'));
 
 		foreach ($this->storages as &$storage) {
 			if (isset($storage['id'])) {
-				$storageQuery->setParameter(0, $storage['id']);
+				$storageQuery->setParameter('id', $storage['id']);
 				$storageQuery->execute();
 				$storage['numeric_id'] = $storageQuery->getLastInsertId();
 			}
 
 			if (isset($storage['share_token'])) {
 				$shareExternalQuery
-					->setParameter(0, $storage['share_token'])
-					->setParameter(1, $storage['remote'])
-					->setParameter(2, 'irrelevant')
-					->setParameter(3, 'irrelevant')
-					->setParameter(4, $storage['user'])
-					->setParameter(5, 'irrelevant')
-					->setParameter(6, 'irrelevant');
+					->setParameter('share_token', $storage['share_token'])
+					->setParameter('remote', $storage['remote'])
+					->setParameter('name', 'irrelevant')
+					->setParameter('owner', 'irrelevant')
+					->setParameter('user', $storage['user'])
+					->setParameter('mountpoint', 'irrelevant')
+					->setParameter('mountpoint_hash', 'irrelevant');
 				$shareExternalQuery->executeStatement();
 			}
 
 			if (isset($storage['files_count'])) {
 				for ($i = 0; $i < $storage['files_count']; $i++) {
-					$filesQuery->setParameter(0, $storage['numeric_id']);
-					$filesQuery->setParameter(1, 'file' . $i);
-					$filesQuery->setParameter(2, md5('file' . $i));
+					$filesQuery->setParameter('storage', $storage['numeric_id']);
+					$filesQuery->setParameter('path', 'file' . $i);
+					$filesQuery->setParameter('path_hash', md5('file' . $i));
 					$filesQuery->executeStatement();
 				}
 			}