fix(db): Fix md5 for oracle >= 20

Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud · Jul 19, 2024 · b79d87c · b79d87c
1 parent 817ca00
commit b79d87c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/lib/private/DB/Connection.php b/lib/private/DB/Connection.php
@@ -749,4 +749,12 @@ public function getDatabaseProvider(): string {
 			throw new \Exception('Database ' . $platform::class . ' not supported');
 		}
 	}
+
+	/**
+	 * @internal Should only be used inside the QueryBuilder, ExpressionBuilder and FunctionBuilder
+	 * All apps and API code should not need this and instead use provided functionality from the above.
+	 */
+	public function getServerVersion(): string {
+		return $this->_conn->getServerVersion();
+	}
 }
diff --git a/lib/private/DB/ConnectionAdapter.php b/lib/private/DB/ConnectionAdapter.php
@@ -232,4 +232,12 @@ public function getInner(): Connection {
 	public function getDatabaseProvider(): string {
 		return $this->inner->getDatabaseProvider();
 	}
+
+	/**
+	 * @internal Should only be used inside the QueryBuilder, ExpressionBuilder and FunctionBuilder
+	 * All apps and API code should not need this and instead use provided functionality from the above.
+	 */
+	public function getServerVersion(): string {
+		return $this->inner->getServerVersion();
+	}
 }
diff --git a/lib/private/DB/QueryBuilder/FunctionBuilder/OCIFunctionBuilder.php b/lib/private/DB/QueryBuilder/FunctionBuilder/OCIFunctionBuilder.php
@@ -12,6 +12,9 @@
 
 class OCIFunctionBuilder extends FunctionBuilder {
 	public function md5($input): IQueryFunction {
+		if (version_compare($this->connection->getServerVersion(), '20', '>=')) {
+			return new QueryFunction('LOWER(STANDARD_HASH(' . $this->helper->quoteColumnName($input) . ", 'MD5'))");
+		}
 		return new QueryFunction('LOWER(DBMS_OBFUSCATION_TOOLKIT.md5 (input => UTL_RAW.cast_to_raw(' . $this->helper->quoteColumnName($input) .')))');
 	}