Skip to content

Commit

Permalink
Merge pull request #38437 from nextcloud/revert-37793-backport/37522/…
Browse files Browse the repository at this point in the history
…stable26

Revert "[stable26] Ungroup `placeholder` css rules to prevent browsers from removing all rules"
  • Loading branch information
nickvergessen authored May 24, 2023
2 parents 93a7d27 + 8ba2f26 commit c075a1e
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion core/css/inputs.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/css/inputs.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 4 additions & 17 deletions core/css/inputs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -826,22 +826,9 @@ label.infield {
overflow: hidden;
}

// when rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated.
// https://www.w3.org/TR/selectors-3/#grouping
// In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome
@mixin placeholder-style {
color: var(--color-text-maxcontrast);
font-size: var(--default-font-size);
}

::placeholder {
@include placeholder-style;
}

::-ms-input-placeholder {
@include placeholder-style;
}

::placeholder,
::-ms-input-placeholder,
::-webkit-input-placeholder {
@include placeholder-style;
color: var(--color-text-maxcontrast);
font-size: var(--default-font-size);
}
2 changes: 1 addition & 1 deletion core/css/server.css

Large diffs are not rendered by default.

Loading

0 comments on commit c075a1e

Please sign in to comment.