Merge pull request #38487 from nextcloud/backport/37522/stable26

[stable26] Ungroup `placeholder` css rules
nextcloud · Jun 7, 2023 · cb5a9fa · cb5a9fa
2 parents 4e8ffe9 + 672d44c
commit cb5a9fa
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 8 deletions.
diff --git a/core/css/inputs.css b/core/css/inputs.css
diff --git a/core/css/inputs.css.map b/core/css/inputs.css.map
diff --git a/core/css/inputs.scss b/core/css/inputs.scss
@@ -826,9 +826,22 @@ label.infield {
 	overflow: hidden;
 }
 
-::placeholder,
-::-ms-input-placeholder,
-::-webkit-input-placeholder {
+// when rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated.
+// https://www.w3.org/TR/selectors-3/#grouping
+// In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome
+@mixin placeholder-style {
 	color: var(--color-text-maxcontrast);
-    font-size: var(--default-font-size);
+	font-size: var(--default-font-size);
+}
+
+::placeholder {
+	@include placeholder-style;
+}
+
+::-ms-input-placeholder {
+	@include placeholder-style;
+}
+
+::-webkit-input-placeholder {
+	@include placeholder-style;
 }
diff --git a/core/css/server.css b/core/css/server.css