Move SCSS variable fetching before the variables.scss to properly cal…

…culate color values Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Aug 29, 2018 · e8938df · e8938df
1 parent 27141a9
commit e8938df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/apps/accessibility/lib/Controller/AccessibilityController.php b/apps/accessibility/lib/Controller/AccessibilityController.php
@@ -149,8 +149,8 @@ public function getCss(): DataDisplayResponse {
 			try {
 				$css .= $scss->compile(
 					$imports .
-					'@import "variables.scss";' .
 					$this->getInjectedVariables() .
+					'@import "variables.scss";' .
 					'@import "css-variables.scss";'
 				);
 			} catch (ParserException $e) {

diff --git a/core/css/variables.scss b/core/css/variables.scss
@@ -38,8 +38,8 @@ $color-main-background: #fff !default;
 $color-background-dark: nc-darken($color-main-background, 7%) !default;
 $color-background-darker: nc-darken($color-main-background, 14%) !default;
 
-$color-primary: #0082c9;
-$color-primary-text: #ffffff;
+$color-primary: #0082c9 !default;
+$color-primary-text: #ffffff !default;
 // do not use nc-darken/lighten in case of overriding because
 // primary-text is independent of color-main-text
 $color-primary-text-dark: darken($color-primary-text, 7%) !default;

diff --git a/lib/private/Template/SCSSCacher.php b/lib/private/Template/SCSSCacher.php
@@ -284,9 +284,9 @@ private function cache(string $path, string $fileNameCSS, string $fileNameSCSS,
 		try {
 			$compiledScss = $scss->compile(
 				'$webroot: \'' . $this->getRoutePrefix() . '\';' .
+				$this->getInjectedVariables() .
 				'@import "variables.scss";' .
 				'@import "functions.scss";' .
-				$this->getInjectedVariables() .
 				'@import "' . $fileNameSCSS . '";');
 		} catch (ParserException $e) {
 			$this->logger->error($e, ['app' => 'core']);
@@ -349,7 +349,7 @@ private function getInjectedVariables(): string {
 		}
 		$variables = '';
 		foreach ($this->defaults->getScssVariables() as $key => $value) {
-			$variables .= '$' . $key . ': ' . $value . ';';
+			$variables .= '$' . $key . ': ' . $value . ' !default;';
 		}
 
 		// check for valid variables / otherwise fall back to defaults