Merge pull request #45932 from carhe/fix-45707

fix(files_versions): avoid unintentional skipping of expiration
nextcloud · Jul 25, 2024 · ebfd493 · ebfd493
2 parents ea7eeb2 + 7eac3fe
commit ebfd493
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php
@@ -896,7 +896,7 @@ public static function expire($filename, $uid) {
 					$pathparts = pathinfo($path);
 					$timestamp = (int)substr($pathparts['extension'] ?? '', 1);
 					$versionEntity = $versionsMapper->findVersionForFileId($file->getId(), $timestamp);
-					if ($versionEntity->getMetadataValue('label') !== '') {
+					if ($versionEntity->getMetadataValue('label') !== null && $versionEntity->getMetadataValue('label') !== '') {
 						continue;
 					}
 					$versionsMapper->delete($versionEntity);