-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid default after upgrade #12031
Comments
@nextcloud/designers |
I personally don't mind :) |
Hehe. For me this not about individual preferences, but about having a smooth transition from NC14 to 15 wrt grid view. So you do not expect any complaining/surprised user by this big visual change? |
@tobiasKaminsky surprise is ok if they like it, I expect positive surprise and not bad feedback ;) |
I would still go for the list view as of now. The switch was always there with the gallery and we got very little complains so far that it is not the default. Let's not change too much. At least that is my opinion. |
@MorrisJobke I'm completely fine with both to be honest :) |
I think it’s very important that we simply default to grid view for 15, and yes, even switch people upgrading to have grid view initially. Why?
So yes – this is intentionally set as new default, also for people upgrading. If there is any "backlash" then there’s a super accessible quick switch, and in any case I take all the blame. |
Let's not talk about who to blame 😁 |
I am not against grid at all, it is really cool. (but I am not that used to web users…) |
I think we can make it default IF it is fully polished. Is there a screenshot somewhere? |
@karlitschek :) |
nice 👍 |
I would close this then. The view is very polished, and because of our clean interface the toggle to change the view is quite visible. And as such, thresholds for changing the view are also not really necessary anymore as they would only be needed when the default is list and you then view an image-only folder. (Hope that’s ok and the reasoning is good @tobiasKaminsky? We can still work out the details of course.) |
I expect a flurry of bug reports the moment we deploy this, but that is to be expected since it's in human nature to fear anything new (at first). I'm a bit worried about low-memory installations (such as RPi) - will it kill those servers (rendering thumbnails) the moment they open up a grid view with hundreds of JPG files? From my experience with the Gallery app, it was almost impossible to use on such a system, because it didn't show image title while thumbnail was loading. I'm really sorry for not having tested the new Grid view (looks great on screenshots, though!), is that handled in a good way? |
@pixelipo good question about the Raspberry Pi setups. Do you know anything about that @skjnldsv @rullzer @jospoortvliet others?
And yep – the usual. :) And people who like stuff never open an issue. 😢 |
@pixelipo this is not highh-res, but it might be good to create either a cron task or a generation-on-upload for later yes :) |
@jancborchardt as this was only a discussion, I am fine with closing it. Maybe you want to think about remembering the preferred view for each folder? |
@tobiasKaminsky yup, that’s definitely a good improvement! Guess it needs some more changes, so more something for 16. Could you open an issue for that? :) |
Reopening as we had some discussions (cc @karlitschek) and feedback – grid view is not polished enough for default yet. @skjnldsv @MorrisJobke I don’t know how to change the default, could you adjust it? |
@jancborchardt could you explain what is missing? :) |
@skjnldsv look in our sales folders for example - most of those files would be indistinguishable because the long file names won't be visible and the thumbnails don't differentiate them. We need to figure out how to change that before we can make this default. Imho in the file selector it looks better - also less clutter with share & ... menu etc. I'm sure these can be resolved but we don't want to make a big change until we're 100% sure it won't be disruptive. |
You did that ;) It's basically assigning a class to the DOM element of the app ;) |
Will need to go into the RC 1 then, because beta 2 is out. |
Not exactly, just toggle the getUserValue and i'll be fine |
@jospoortvliet good point – see my comment on the issue about grid view filename readability which would reduce the visible actions: #12135 (comment) |
I noticed that grid view is default after upgrade, which might scare some people ;-)
Looking at Android and what we discussed there:
If you really want to have grid view as default, maybe because it is common on desktop file browser, maybe consider this:
The text was updated successfully, but these errors were encountered: