-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG issues after upgrade #2564
Comments
cc @juliushaertl any idea bere? |
@Lartza @jancborchardt will have a look later 😉 |
@Lartza can you check if the icon files in The audio.svg errors seem to be related to the preview rendering. I currently can't find any issue on the icon generation, also a upgrade from 10.0.1 to 11 RC1 like you've described works fine here with the icons, but we should make sure that issues will not store empty files. I'll prepare a PR for that. |
@juliushaertl The icon files are readable and the folders up to there are executable. I'm guessing this needs some specific circumstances to be reproduced since it was a production server I upgraded. Writing above I realized I took a database and file backup before I started upgrading back in 10.0.1 so I could try to reproduce this with some work and I might just do that later, didn't think of that before. |
It would be great if you could try to reproduce. I have added a check for empty images in #2588 so even if there is a temporary issue with the icon file, we should not store them but try again on the next request. |
Steps to reproduce
Expected behaviour
Folders have a folder icon shown before them, no errors about SVG images.
Actual behaviour
Folders miss the folder.svg icon and instead a blank space is shown. Log has an error after the update and shows errors weirdly enough for audio.svg. audio.svg error showed constantly browsing the Files app and was logged last ~20 minutes before changing colors in the Theming app so assuming it was fixed by that action.
data/appdata_xxxx/theming/1/icon-core-filetypes_folder.svg is an empty file. Still gets served correctly as image/svg+xml so no errors in nginx or browser. Browsing /apps/theming/img/core/filetypes/folder.svg?v=X makes the browser to try and interpret the 0 bytes as XML.
folder.svg error only appeared ONCE just before regenerating because I deleted data/appdata_xxxx/theming/1/icon-core-filetypes_folder.svg to try and regenerate it before changing color in the Theming app.
Going to theming and changing the color to something else and back regenerated the folder.svg succesfully. audio.svg error stopped happening little before this action as per above.
Server configuration
Operating system: Arch Linux
Web server: nginx 1.11.6
Database: PostgreSQL 9.6.1
PHP version: 7.0.13
Nextcloud version: 11.0 RC1
Updated from an older Nextcloud/ownCloud or fresh install: Upgrade 10.0.2RC2 > 11 RC1 (also 10.0.1 > 10.0.2 RC2 before that but error appeared in 11)
Where did you install Nextcloud from: zip or bz2
Signing status:
Signing status
List of activated apps:
App list
The content of config/config.php:
Config report
Are you using external storage, if yes which one: No
Are you using encryption: no
Are you using an external user-backend, if yes which one: No
Client configuration
Browser: Firefox 50.0.2
Operating system: Windows 10
Logs
Nextcloud log (data/nextcloud.log)
Nextcloud log
The text was updated successfully, but these errors were encountered: