Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag usage through ~all apps #13330

Closed
mat-m opened this issue Jan 3, 2019 · 18 comments
Closed

Tag usage through ~all apps #13330

mat-m opened this issue Jan 3, 2019 · 18 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@mat-m
Copy link

mat-m commented Jan 3, 2019

Is your feature request related to a problem? Please describe.

  • I can tag my files, and so my photos
  • I can categorize my notes
  • I can tag my bookmarks
  • I can categorize my tasks

First problem:

  • I can have many tags for files & bookmarks
  • I can have many categories for tasks
  • I can have only one category for notes

So two terms and two behaviors, but they do not match.

Describe the solution you'd like

I would like to be consistent:

  • Have tags everywhere, thus allowing to have many tags for one object
  • Tags list being shared between apps.

Additional context

  • This will allow a consistent taxonomy on your objects (tasks, bookmarks, ....)
  • This will induce a capability to find all objects related to a tag.

Example:
I use the tag recipe to track my recipes, and the tag cooking for the things to try in the kitchen
I have a pdf of a recipe, which I tag with cooking and recipe
I pasted another recipe in a note, which I only tag recipe because I already did it with my mother last week.
I bookmarked a third recipe, and tag it with cooking and recipe
I uploaded a photo of a recipe from a book taken during a trip in Italy, which I tag with cooking and recipe
I create a task Schedule invitations for cooking tag which I tag with cooking

We may then envision to have a global tag search, so that if I search for tag cooking, it will show me all the objects tagged with it (files, photos, tasks, bookmarks, notes).

@mat-m mat-m added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 3, 2019
@Spartachetto
Copy link

It seems to me that this tags unification for all the apps was already considered.
Maybe @nickvergessen can provide additional information and decide how to deal with this issue.

@Spartachetto
Copy link

Related issue in Tasks repository: nextcloud/tasks#89

I did not manage to find a similar issue for bookmarks and notes (I did a quick search...)

@nickvergessen
Copy link
Member

Yeah, we have "System tags" which should serve exactly this purpose. So in theory you should open a new issue in all of the affected apps and ask them to use the system tags instead of implementing yet another tagging system.

@Spartachetto
Copy link

Spartachetto commented Jan 9, 2019

Maybe the way to integrate "System tags" could be a bit more straightforward?

@nickvergessen Is it useful to collect here the issues in all the different apps?

For example in deck there is nextcloud/deck#201 ; in calendar there is nextcloud/calendar#107

@Spartachetto
Copy link

Spartachetto commented Jan 11, 2019

I will try to create an overall synthesis that can be useful to the developers. And then @MorrisJobke will have the possibility to manage the issue more quickly.

Two considerations:

  1. the fact that a tag is a system tag should be optional?
  • If not, probably that would mean that the number of system tags could be bigger; that could lead to the necessity of better tools for the management of tags
  • If yes, that would add a different complexity in the attribution of a tag to an object (contact, calendar item, ...) or in the management of tags; for each tag the user should decide if it is a system tag or not
  1. maybe I am off track but this issue could be related to Circles, contact groups and user groups #13478 . We could have an unique "definition" of tags in all the apps as well as an unique "definition" of user groups in all the apps

list of App related issues:

I did not insert apps like Audio Player because I think that mixing the tags internal to Nextcloud with the tags that derive from metadata inserted in the file format (like MP3) is another issue.

@mat-m
Copy link
Author

mat-m commented Jan 14, 2019

Thanks @Spartachetto for consolidating information.
I will try to open missing issues this week on notes & bookmarks.
Mails are not shareable, I would rather ask for a "Save to nextcloud as HTML", in the same way we can save attachments.
News can be shared, so that is another way to think about it.
IMO, it makes sense for polls. A poll is rarely a standalone task, but rather an item in a project, a workflow, which is my purpose for tags. To reuse my example, I may set a poll to let my guests choose their recipe :)

@nickvergessen
Copy link
Member

Adding announcements nextcloud/announcementcenter#2

@Spartachetto
Copy link

Spartachetto commented Jan 15, 2019

@mat-m What do you mean by "Mails are not shareable"?

If you are interested in sharing different kinds of objects together, you could be interested in the idea of collections ( #11015 ).

As you were describing the use of system tags as a classification of all your different objects related to something, I have the impression that emails could be of interest.

Mind to clarify why you do not agree? Thank you in advance!

@mat-m
Copy link
Author

mat-m commented Jan 16, 2019

@Spartachetto , Mailboxes are only IMAP, so mails are on the server. I don't see a way to share a mail that is in your mailbox with others.
Collections are one way to do it, but I also think that having a centralized tags definition is a key point for data and metadata consistency.

@Spartachetto
Copy link

If this global use of system tags will be realized, #2143 would be even more useful....

@Spartachetto
Copy link

I do not know if you would include also #16885 here. @nickvergessen what do you think?

@marcelklehr
Copy link
Member

Could someone point to documentation on how to integrate system tags?

@sunjam
Copy link

sunjam commented Dec 21, 2019

Here is the api documentation for version 17.

@marcelklehr
Copy link
Member

marcelklehr commented Dec 21, 2019

This is probably the relevant public API, however, as usual, it's quite minimal. If there is a feature in core that is supposed to be used by apps, I would expect to see explanations and guides on how it works and how it is supposed to be used. The absence of documentation, makes it clear why no app developer has implemented this. As it is, the developer experience in general is quite underwhelming atm, IMHO.

@Spartachetto
Copy link

Spartachetto commented Dec 23, 2019

As @marcelklehr is an experienced app developer, I think it is a warning sign if even he thinks that the documentation is lacking.

I do not know if @nickvergessen is the right one to solve the problem. Otherwise maybe he can pass the message to the right persons...

@nickvergessen
Copy link
Member

If you have a specific question I may be able to point you to some code. But I'm pretty bad at writing generic documentations. Mean while the API docu is down temporarily, but yeah https://github.com/nextcloud/server/tree/5bf3d1bb384da56adbf205752be8f840aac3b0c5/lib/public/SystemTag is your home. Use ISystemTagManager to get/create a tag and ISystemTagObjectMapper to add it to and remove it from items, or get the list of tags on an item.

Your items identify by the object type (files e.g. for the system tags you can put on files) and an object id (the file id for files, in talk we would use the conversation token, etc). Hope that helps?

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2020

CLosing as dedicated tickets have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

6 participants