Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync (Push) notifications #13980

Open
10 of 12 tasks
tobiasKaminsky opened this issue Feb 1, 2019 · 20 comments · Fixed by #15040
Open
10 of 12 tasks

Sync (Push) notifications #13980

tobiasKaminsky opened this issue Feb 1, 2019 · 20 comments · Fixed by #15040

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Feb 1, 2019

Done

  • Android
  • iOS
  • Desktop
  • Server

When receiving a notification:

On Android/iOS:

  • you get a push notification (displayed as popup/ in statusbar)
  • you can click on it, get redirected to list of notifications
  • on iOS you can delete notifications via swipe (get also deleted on server)

On Desktop:

  • polling of notifications

Missing:
iOS @nextcloud/ios:

  • "delete" action on push notification is missing
  • handle incoming "delete" push notification

Android @nextcloud/android:

On server @nickvergessen:

  • once a notification is dismissed this should be sent as "deleted" event with id to all devices so they can remove the pending push notification

Desktop @nextcloud/desktop:

@tobiasKaminsky tobiasKaminsky added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap client: 💻 desktop client: 🤖🍏 mobile labels Feb 1, 2019
@rullzer rullzer added overview and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 1, 2019
@tobiasKaminsky
Copy link
Member Author

  • once a notification is dismissed this should be sent as "deleted" event with id to all devices so they can remove the pending push notification

@nickvergessen can I send custom push notifications to me, so that I can test this?

@nickvergessen
Copy link
Member

https://github.com/nextcloud/notifications/blob/master/docs/admin-notifications.md

@tobiasKaminsky
Copy link
Member Author

This works really nice:

  • send a notification with "delete:$id" as subject
  • on receiving a push notification, I first check for delete subject, if not regular notification is shown else I delete the shown notification (if available)

@nickvergessen this is of course only a test and should then be done in a safer way, maybe we can use "app" for this? "delete_notification" as app.
Also this notification then should not be shown/stored at all on server.

(https://github.com/nextcloud/notifications/blob/master/docs/push-v2.md)

@rullzer
Copy link
Member

rullzer commented Feb 12, 2019

* on receiving a push notification, I first check for delete subject, if not regular notification is shown else I delete the shown notification (if available)

Only delete it if the id matches of course ;)

@marinofaggiana
Copy link
Member

Hi, next week I will implement this ... now I am too busy for remake of tab "Media" ...

@tobiasKaminsky
Copy link
Member Author

For receiving "hidden" push messages to delete the notifications on screen, we would need implementation by @nickvergessen.

@nickvergessen
Copy link
Member

First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up

@tobiasKaminsky
Copy link
Member Author

Ah, ok did not know about iOS internals, but on Android we receive a push and then can decide if we want to show a notification.

But then this is step 2 :-)

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 13, 2019

Soon !! (next week) @Ivansss ;)

@tobiasKaminsky
Copy link
Member Author

ping @rullzer to have a look into push server side

@nickvergessen
Copy link
Member

Why?

@tobiasKaminsky
Copy link
Member Author

@nickvergessen cause you are busy in talk and we wanted to keep work off you.

@tobiasKaminsky
Copy link
Member Author

First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up

@marinofaggiana have you already switched to PushKit?

@nickvergessen
Copy link
Member

Yes, it was done yesterday+today.

However beta2 just went out, i guess we have to wait one more release?

@tobiasKaminsky
Copy link
Member Author

Great to hear :-)
Then we can start implementing it. I guess, @nickvergessen the server/app has to start, or? 🎉

@tobiasKaminsky
Copy link
Member Author

Re-opening as this is missing on desktop (sync without push) and iOS.

@MorrisJobke
Copy link
Member

Re-opening as this is missing on desktop (sync without push) and iOS.

cc @camilasan @marinofaggiana

@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

Is this still not yet implemented on Desktop and iOS? If it is, please close this issue. Thanks!

@rakekniven
Copy link
Member

iOS is done.

@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

cc @nextcloud/desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants