-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete notification in notification list #3607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
previously approved these changes
Feb 11, 2019
tobiasKaminsky
force-pushed
the
notificationList
branch
from
February 12, 2019 06:49
5fc786f
to
fc5db89
Compare
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
===========================================
+ Coverage 6% 6.04% +0.03%
Complexity 1 1
===========================================
Files 313 316 +3
Lines 30774 30821 +47
Branches 4427 4426 -1
===========================================
+ Hits 1847 1862 +15
- Misses 28651 28681 +30
- Partials 276 278 +2
|
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
===========================================
- Coverage 6.06% 6.05% -0.01%
Complexity 1 1
===========================================
Files 312 315 +3
Lines 30712 30762 +50
Branches 4418 4418
===========================================
Hits 1863 1863
- Misses 28572 28622 +50
Partials 277 277
|
tobiasKaminsky
changed the title
also extract execute action task
Delete notification in notification list
Feb 12, 2019
12 tasks
ignore compound warning renamed RemoteOperation Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
notificationList
branch
3 times, most recently
from
February 13, 2019 08:18
a8e78da
to
8bf3f73
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
notificationList
branch
from
February 13, 2019 08:36
8bf3f73
to
941239c
Compare
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7891 |
Lint
FindBugs (new)
FindBugs (master)
Android-library is not set to master branch in build.gradle |
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Lint
FindBugs (new)
FindBugs (master)
|
This was referenced Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me