Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete notification in notification list #3607

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Conversation

tobiasKaminsky
Copy link
Member

2019-02-11-124629

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3607 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3607      +/-   ##
===========================================
+ Coverage         6%   6.04%   +0.03%     
  Complexity        1       1              
===========================================
  Files           313     316       +3     
  Lines         30774   30821      +47     
  Branches       4427    4426       -1     
===========================================
+ Hits           1847    1862      +15     
- Misses        28651   28681      +30     
- Partials        276     278       +2
Impacted Files Coverage Δ Complexity Δ
.../android/ui/asynctasks/DeleteNotificationTask.java 0% <0%> (ø) 0 <0> (?)
...d/ui/asynctasks/NotificationExecuteActionTask.java 0% <0%> (ø) 0 <0> (?)
...oud/android/ui/activity/NotificationsActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ud/android/ui/adapter/NotificationListAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...roid/ui/asynctasks/DeleteAllNotificationsTask.java 0% <0%> (ø) 0 <0> (?)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 4 more

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3607 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3607      +/-   ##
===========================================
- Coverage      6.06%   6.05%   -0.01%     
  Complexity        1       1              
===========================================
  Files           312     315       +3     
  Lines         30712   30762      +50     
  Branches       4418    4418              
===========================================
  Hits           1863    1863              
- Misses        28572   28622      +50     
  Partials        277     277
Impacted Files Coverage Δ Complexity Δ
.../android/ui/asynctasks/DeleteNotificationTask.java 0% <0%> (ø) 0 <0> (?)
...oud/android/ui/activity/NotificationsActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...d/ui/asynctasks/NotificationExecuteActionTask.java 0% <0%> (ø) 0 <0> (?)
...ud/android/ui/adapter/NotificationListAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...roid/ui/asynctasks/DeleteAllNotificationsTask.java 0% <0%> (ø) 0 <0> (?)

@tobiasKaminsky tobiasKaminsky changed the title also extract execute action task Delete notification in notification list Feb 12, 2019
@nextcloud nextcloud deleted a comment Feb 13, 2019
@nextcloud nextcloud deleted a comment Feb 13, 2019
ignore compound warning
renamed RemoteOperation

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger force-pushed the notificationList branch 3 times, most recently from a8e78da to 8bf3f73 Compare February 13, 2019 08:18
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings6868
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings120
Internationalization Warnings15
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings58
Dodgy code Warnings125
Total484

FindBugs (master)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings120
Internationalization Warnings15
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings58
Dodgy code Warnings125
Total484

Android-library is not set to master branch in build.gradle

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings6868
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings120
Internationalization Warnings15
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings58
Dodgy code Warnings125
Total484

FindBugs (master)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings120
Internationalization Warnings15
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings58
Dodgy code Warnings125
Total484

@AndyScherzinger AndyScherzinger merged commit 77947fb into master Feb 13, 2019
@AndyScherzinger AndyScherzinger deleted the notificationList branch February 13, 2019 14:03
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.6.0 milestone Feb 13, 2019
@nextcloud nextcloud deleted a comment Feb 13, 2019
@nextcloud nextcloud deleted a comment Feb 13, 2019
@nextcloud nextcloud deleted a comment from AndyScherzinger Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants