Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox - User Settings - Some svg icons not visible #23849

Closed
Eninspace opened this issue Nov 2, 2020 · 1 comment · Fixed by #27936
Closed

Firefox - User Settings - Some svg icons not visible #23849

Eninspace opened this issue Nov 2, 2020 · 1 comment · Fixed by #27936
Labels
2. developing Work in progress bug design Design, UI, UX, etc. feature: settings good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@Eninspace
Copy link

It is a visual bug appears on the settings page when there are many characters in the string. I think this is due to css

#app-navigation:not(.vue)>ul>li>ul>li>a
overflow: hidden;

which hides the icon along with the overflow text. If you comment out overflow: hidden; icons appear

Steps to reproduce

  1. Set Russian languages
  2. Open User Setting Page

Expected behaviour

All Icons in the left side bar are displayed correctly

Actual behaviour

Some icons don't displayed

изображение изображение

Server configuration

**Operating system:Ubuntu

**Web server:Apache

**Database:PostgreSQL 12.4

**PHP version:7.4.3

**Nextcloud version:19.0.4

Updated from an older Nextcloud/ownCloud or fresh install:

**Where did you install Nextcloud from:Nextcloud official website

Client configuration

**Browser:Firefox 82.0.2
**Operating system:Windows 10
@Eninspace Eninspace added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 2, 2020
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: settings and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 7, 2020
@olivierperdaens olivierperdaens mentioned this issue Nov 25, 2020
Closed
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Fix svg icons disapearing in app navigation when text overflows
e1a245c 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins.

This fix nextcloud#23849
@CarlSchwan CarlSchwan mentioned this issue Jul 13, 2021
Merged
@szaimen

This comment has been minimized.

Sign in to view
@szaimen szaimen added 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jul 13, 2021
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Fix svg icons disapearing in app navigation when text overflows
99e845d 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix nextcloud#23849
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Fix svg icons disapearing in app navigation when text overflows
d0afc49 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix nextcloud#23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 13, 2021
@CarlSchwan @backportbot
Fix svg icons disapearing in app navigation when text overflows
1e88f23 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 13, 2021
@CarlSchwan @backportbot
Fix svg icons disapearing in app navigation when text overflows
bee85ab 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 13, 2021
@CarlSchwan @backportbot
Fix svg icons disapearing in app navigation when text overflows
e8259bf 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit that referenced this issue Jul 14, 2021
@CarlSchwan
Fix svg icons disapearing in app navigation when text overflows
6505312 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress bug design Design, UI, UX, etc. feature: settings good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix svg icons disapearing in app navigation when text overflows CarlSchwan/server
3 participants
@skjnldsv @Eninspace @szaimen