Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previews for empty files broken #2413

Closed
schiessle opened this issue Nov 29, 2016 · 2 comments
Closed

Previews for empty files broken #2413

schiessle opened this issue Nov 29, 2016 · 2 comments
Assignees
@rullzer
Labels
bug feature: versions
Milestone
Nextcloud 11.0

Comments

@schiessle
Copy link
Member

Steps to reproduce:

  1. Create a empty text file in the web ui
  2. edit the file and add some content
  3. go to versions drop down

Result:

broken preview for the empty version of the file (should fall back to the mime icon)

versions

cc @rullzer
@rullzer
Copy link
Member

rullzer commented Nov 29, 2016

I'll have a look

rullzer added a commit that referenced this issue Nov 29, 2016
@rullzer
Show mimeicon when versions don't have a preview
4dcd047 
Fixes #2413

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this issue Nov 29, 2016
Merged
@rullzer rullzer self-assigned this Nov 29, 2016
@rullzer
Copy link
Member

rullzer commented Nov 29, 2016

Fix in #2414

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Nov 30, 2016
blizzz pushed a commit that referenced this issue Dec 7, 2016
@rullzer @blizzz
Show mimeicon when versions don't have a preview
39f3f22 
Fixes #2413

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@nextcloud-bot nextcloud-bot mentioned this issue Jul 4, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 27, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Oct 3, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Oct 18, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Nov 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rullzer rullzer

Labels
bug feature: versions
Projects
None yet
Milestone
Nextcloud 11.0
Development

No branches or pull requests
3 participants
@rullzer @MorrisJobke @schiessle