-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to disable users #283
Comments
Alternative workaround:
|
That's already possible with |
Thanks @ChristophWurst ... Missed that 😁 Maybe it should be possibile via webinterface 😁 cc @nextcloud/designers |
@karlitschek @LukasReschke do we want this function in the interface? Since we're thinking about it, is there a list of commands possible via occ so we can see which make sense to have in the UI and which not? |
Todays master:
|
Disable User would be useful. 👍 |
Maybe just add another checkbox "disabled" next to Admin? Users should not be able to disable their own Account, to prevent Lockout |
@jancborchardt Sure. Having this in the UI would be nice. Not sure if there is a nice place. |
@Mar1u5 maybe a Ban feature would also be useful for several functions. For example to ban a user for 5 days from the calendar function or conference function. I don't know whether it would be so good to disable the whole account. Are there any specific use-cases? |
Yes there are use cases.
Banning them would not make sense I think. What would be the use-case for this? @bes1002t |
Banning would make more sense if used more like an account lockout feature, user gets password wrong 5 time from the same IP = 'ban for 20 mins.' |
Banning and disabling should be to separate issues I think. There are also some issue around brute-forcing login data. Maybe banning can be included there. Would also be nice. |
I would expect to find this in the ui, in the same place as where the admin can currently delete users, in the users area. I would expect an icon such as a circle, with a diagonal bar, to appear next to the garbage can icon for deleting them. Needless to say, we should confirm before blocking users. ;) |
So probably it makes sense to replace the delete icon in the list with a 3-dot action menu like in Files. In there would be »Deactivate« and »Delete«. |
Since we are thinking about occ commands in the UI, how about including files:scan (both per user for personal uploaded files and for the admin to re-scan at the system level? |
@totalcaos no, sorry. This should of course work automatically, and any option like that in the interface would just be like stating something doesn't work. |
@jancborchardt I see where you are coming from, but would the auto scan of work when files are uploaded (specially in bulk) via webdav or ftp when the user does not have shell access? |
@totalcaos should be, yes. If it doesn't then please open a separate issue because we don't want to derail this one. :) |
I added the ability to enable/disable users through the admin menu. As @jancborchardt proposed, I replaced the current delete icon with an action menu. |
Hi Thomas, Thanks for implementing the disable user feature! Is it possible to have a Use Case: I get a lot of temporary contract workers during our busy periods (most of With the multi-select checkbox I could easily select the users (who are I guess what I am saying is the ability to disable/delete multiple users On Mon, Jul 11, 2016 at 10:22 PM, Thomas Pulzer notifications@github.com
|
I think we could implement it like in the files section, where you have sort of a global action menu, acting on selected users. |
Ouch! @Faldon that's a tough one. Personally I would get user confirmation before mass deletion and drop the "undo" function. Trying to dispaly a stacked notification could clutter up the UI quite badly. I think we will need some guidance from @karlitschek, @MorrisJobke and @LukasReschke on this along with community feedback :) For the short term, will it be practical to leave out the "delete" functionality and focus on purely the "disable" action |
@totalcaos mass selection is an entirely different thing, so please again: open a separate issue for that and let's focus on one thing at a time. :) @Faldon great stuff! :) Check out the classes / HTML structure of the dropdown in the Files app is probably easiest to get the styles over. You could also just open a work-in progress pull request and we can collaborate on this. |
@jancborchardt Than I will think I will revert to my first version, with a dropdown menu on every user, for now. Instead of the red stripes we go with a "Disabled" user group. @totalcaos I save the code for the mass editing in a separate branch. Than we can discuss, how to implement it best and with save defaults. |
@Faldon @jancborchardt that's cool. I'll raise another ticket to deal with bulk disable/delete of users and link it back to this ticket for reference. |
New PR (rebase on master) is in #1234 |
Implemented in #1234 |
Is there a way to disable the user from the OCS Api? |
The OCS API provides you the enabled status (https://docs.nextcloud.com/server/12/developer_manual/client_apis/OCS/index.html#user-metadata) with the parameters To disable/enable a user you can use the WebUI or the |
Feature
Sometimes you don't want to delete somebodies account. Disabling would be an option. This would prevent users from logging in, resetting their passwords without deleting any files and settings.
Requested here: https://help.nextcloud.com/t/ability-to-disable-users/
Workaround:
Change users password (Problem: User is able to reset it with email)
The text was updated successfully, but these errors were encountered: