-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL (Right-to-Left) text direction for some Asian languages such as Arabic, Hebrew, Persian etc. #31420
Comments
There should be some work already done. I've seen for example #11716 |
Perhaps a stupid question, you probably would change the alignment, but would you as well "mirror" the whole design? |
@jancborchardt Sorry to disturb you, but:
|
the issue is not solved yet. |
There are some problems for Right-to-Left languages.
|
cc @skjnldsv @marcoambrosini @PVince81 @AndyScherzinger since this is quite an overarching front-end issue. |
Not sure when this could be picked up, since we want to push more for the rewrite to vue and also work on accessibility which both couldn't be worked on given the priorities of version 24. So I think that this should be implemented first before improving RTL support. |
Isn't there anything about RTL layout support for Version 25? |
Not that I know of, maybe @PVince81 is aware of something, but my guess it no. |
it is a front-end issue . the direction must rely on the used language to view the text and tables and containers properly. |
I have tried manually, and I think the implementation of this feature should be straight forward. If there is no objection against using logical properties in CSS (I mean using Perhaps the only issue is with the support for If there be no objection, this approach helps us to avoid creating rtl styles (which brings more headache for maintenance). Then we need to publish some guidelines for developing apps to respect the same styling conventions to follow the direction of the page. Green light? |
#31420 (comment) What do you think @skjnldsv @nickvergessen @juliushaertl @artonge @ChristophWurst - for some front-enders feedback. In general having RTL supported would be awesome, I just lack the technical knowledge if the approach works or where one would expect challenges and side-effects for app-developers |
The good thing is that my native language is Persian (so I know what I am fixing). I also have several contributions to different projects, fixing their bidirectional text support. I expect the changes to be very limited, so it shouldn't add more complexities to the project. I document things so they can become a guideline for other developers. We only need a reliable way to verify the quality of the changes. If we have automated tests, it would be great. In any case, we will make it work. I have some cool plans for the next 3 months. Wish me for making it realized. |
That sounds awesome @ahangarha 🎉 Also if you have any troubles from a design perspective feel free to loop in people from @nextcloud/designers or @jancborchardt or @nimishavijay specifically. Really looking forward to have RTL languages properly supported ✨ |
Great news. Any progress on this feat. My mother language is Arabic, so I can help on reviewing the result and QA. |
@alimahwer No progress yet. But it is good to have you for testing |
I can help you with Persian strings. |
So is this solved in this pull request? |
No @GameO7er |
Thank you for your response. |
A few colleagues and I are working on adding bidirectional text support to NC server. There are a few blockers. Should I discuss them here?
For now, I don't touch these cases. Please let me know how we can resolve these issues. |
Since nextcloud server uses this browserslist, then I think we can totally ignore IE11. But still we have Samasung Internet and Opera Mobile. May I ignore them as well or you want to keep them in the list? These two browsers don't proper support for logical CSS properties. |
Thanks a bunch for looking into this @ahangarha! :)
@AndyScherzinger what do you think? Also @danxuliu could that commit/fix be done in a different way?
As far as I know, the tooltip library is being phased out in favor of the native browser title/tooltip functionality, so this might soon be obsolete. cc @JuliaKirschenheuter @ShGKme for more info. |
I'd be looping in @sorbaugh for the server part. see https://docs.nextcloud.com/server/latest/user_manual/en/webinterface.html - we do not supprot IE11 in latest versions of Nextcloud. As stated by Jan we also phased out the tooltip library in favor of native tooltips with v27. |
The commit is 4years old, and the person is OOO for another 2.5 months. |
Yep, it is mostly removed. Some places still use it, but we probably will remove it completely. |
Great. If I get green light for dropping this browser too, I can wrap up and make the PR in 24 hours. I must say, this is just the beginning of a series of changes all over NextCloud. These changes wont affect LTR languages (visually) but RTL languages will be impacted (since in some apps they see the content in RTL while the text is LTR; the same issue they face with RTL content in LTR layout even now). So we are moving forward but the team should be aligned and synced about the progress we are going to make. |
According to Statcounter, Samsung Internet has a current market share of 4.58% on mobile: https://gs.statcounter.com/browser-market-share/mobile/worldwide |
That is what is concerning me. I wish there be some statistics about NC users who use this browser. But I think I can find some workaround if NC wants to support this browser. |
@ahangarha yeah, we don’t do tracking in this regard though. But considering the many people who use Nextcloud either not only self-hosted but also via companies, schools, governments, very common service providers and more → We have to take the Statcounter values and take them as if they are our own. Thus Samsung Internet is not something we can not support, sorry. :( Hope that’s understandable? |
@jancborchardt I have already taken that into account while working on #42471, and I hope I can get some response in that regard and move forward. |
So anyone can try out the latest master and report back any issues you find that still need fixing/polishing. Some might be here in the server some might be in libraries or apps. Don't worry if unclear, we will take care of transferring the issue to the matching repo in case it is needed 👍 |
##Issue
We need to use Persian interface and Persian (Farsi) is a RTL language. This feature is not supported in Nextcloud and the interface strings are translated into Persian but its Left-to-Right.
We have also checked Arabic and it was also LTR.
##What we suggest:
We strongly suggest that Nextcloud developers include the text direction feature.
The text was updated successfully, but these errors were encountered: