-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] 9.4.1.2/3.8 - The tables (including table in the dialog "Choose target folder") are sortable, but the sorting status is only visible to visual users. (2) #37105
Comments
Our current implementation now uses buttons like below
With the sort order being within the label instead of a separate I suppose the ideal implementation would use |
Hi @michaelnissenbaum - any feedback on #37105 (comment) ? Thanks in advance |
I would also prefer the solution described at https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-sort or https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/. The use of the "aria-pressed" attribute is not necessary. Using only "aria-sort" on the "th" element is sufficient. Also, take a look at the article https://adrianroselli.com/2021/04/sortable-table-columns.html - "If your column is not sorted, instead of using aria-sort="none" remove the attribute instead. You should not use aria-sort on more than one column header at a time.". |
Is dialogs lib ready for another beta @susnux ? |
@Pytal sure, but I would really like to have nextcloud-libraries/nextcloud-dialogs#1070 merged first |
@Pytal released feel free to update server |
One possibility to make the sorting status available to users of assistive technologies would be to use the aria-sort attribute. Additionally, the implementation of sorting buttons using links is incorrect. Button elements should be used instead.
See https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ for reference.
Files
File picker
aria-sort
Details
https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-bfbf07e5c3-v3-n8
The text was updated successfully, but these errors were encountered: