Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.4.1.2/3.8 - The tables (including table in the dialog "Choose target folder") are sortable, but the sorting status is only visible to visual users. (2) #37105

Closed
6 tasks done
AndyScherzinger opened this issue Mar 7, 2023 · 6 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 7, 2023

One possibility to make the sorting status available to users of assistive technologies would be to use the aria-sort attribute. Additionally, the implementation of sorting buttons using links is incorrect. Button elements should be used instead.

See https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ for reference.

Files

File picker

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-bfbf07e5c3-v3-n8

@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility labels Mar 7, 2023
@AndyScherzinger AndyScherzinger changed the title [BITV] 9.4.1.2/3.8 - The tables (including table in the dialog "Choose target folder") are sortable, but the sorting status is only visible to visual users. One possibility to make the sorting status available to users of assistive technologies would be to use the aria-sort attribute. Additionally, the implementation of sorting buttons using links is incorrect. Button elements should be used instead. (2) [BITV] 9.4.1.2/3.8 - The tables (including table in the dialog "Choose target folder") are sortable, but the sorting status is only visible to visual users. (2) Mar 7, 2023
@Pytal Pytal self-assigned this Aug 16, 2023
@Pytal
Copy link
Member

Pytal commented Sep 1, 2023

Our current implementation now uses buttons like below

th
  button aria-label="Sort list by Name (ascending)"
th

With the sort order being within the label instead of a separate aria-sort

I suppose the ideal implementation would use aria-sort & aria-pressed as described in https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-sort @michaelnissenbaum ?

@AndyScherzinger
Copy link
Member Author

Hi @michaelnissenbaum - any feedback on #37105 (comment) ? Thanks in advance

@michaelnissenbaum
Copy link

I would also prefer the solution described at https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-sort or https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/. The use of the "aria-pressed" attribute is not necessary. Using only "aria-sort" on the "th" element is sufficient. Also, take a look at the article https://adrianroselli.com/2021/04/sortable-table-columns.html - "If your column is not sorted, instead of using aria-sort="none" remove the attribute instead. You should not use aria-sort on more than one column header at a time.".

@Pytal Pytal added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 12, 2023
@Pytal
Copy link
Member

Pytal commented Oct 16, 2023

Is dialogs lib ready for another beta @susnux ?

@susnux
Copy link
Contributor

susnux commented Oct 17, 2023

Is dialogs lib ready for another beta @susnux ?

@Pytal sure, but I would really like to have nextcloud-libraries/nextcloud-dialogs#1070 merged first

@susnux
Copy link
Contributor

susnux commented Oct 17, 2023

@Pytal released feel free to update server

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2023
@Pytal Pytal closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Development

No branches or pull requests

4 participants