Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add 'target = "_blank"' to the link 'List of invalid files' in Settings > Admin > Overview #41050

Open
zybersup opened this issue Oct 23, 2023 · 3 comments · May be fixed by #41659
Open

Please add 'target = "_blank"' to the link 'List of invalid files' in Settings > Admin > Overview #41050

zybersup opened this issue Oct 23, 2023 · 3 comments · May be fixed by #41659
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: settings good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@zybersup
Copy link

Due to some causes in updating Nextcloud, some files do not passed the integrity check often and the link to view the list of those files is displayed on the Overviewe - Admin Settings. Clicking the link will bring you to the simple page displaying the list. The page is without the normal theme/style of the other Nextcloud pages. I always feel I do something wrong or there is something wrong at the Nextcloud server so it brings me out of the main flow of working to the point of totally server failure. Also I always want to see the list along with working on the Nextcloud at the same time.

I would like to suggest adding target = "_blank" to the link to keep us on the main flow of work together with looking the list and to make us feel safe with this small error too.

I find that the place to add it is at the line 320 in core/js/setupchecks.js.

Thanks

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@zybersup zybersup added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Oct 23, 2023
@joshtrichards joshtrichards added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: settings labels Nov 11, 2023
@fitrahmunir
Copy link

Hi @zybersup @joshtrichards May I work on this?

@joshtrichards
Copy link
Member

Certainly @fitrahfm

@fitrahmunir fitrahmunir linked a pull request Nov 22, 2023 that will close this issue
Open
8 tasks
@fitrahmunir
Copy link

Hi @joshtrichards I have just submitted a pull request for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: settings good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(UserMenu): add target property to usermenu component fitrahmunir/nextcloud-server
3 participants
@joshtrichards @zybersup @fitrahmunir