feat(UserMenu): add target property to usermenu component

[fitrahmunir]

• Resolves: Please add 'target = "_blank"' to the link 'List of invalid files' in Settings > Admin > Overview #41050

Summary

Add target property to UserMenu and UserMenuEntry components and add target "_blank" to Administration settings

TODO

• Add target property to UserMenu and UserMenuEntry components
• Add target "_blank" to admin_settings

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Failing CI is related:

[nickvergessen]

I don't think the admin settings should open in a new tab all the time?
Neither the user menu links...

cc @nextcloud/designers

[marcoambrosini]

This is an old one.. I agree with the proposed change. I think that admin settings and personal settings, and all apps for that matter, should open in another tab. This solution:

• Reduces friction: once I'm done with the admin settings work, I don't have to remember where I was and what I was doing. I just close the tab and the first thing I see is my work exactly where I left it.
  Moreover, had open settings in the same tab, the state of the app that I navigated away from is not saved, and will likely never be saved:
  It has been suggested in the past that we could "remember" the state of each app, but this is hard to implement and maybe not even desirable in most cases. In any event, we'd be reinventing something that's already there at the browser level: multitasking. So in my opinion it's not a wise allocation of resources.

• Cuts on lading times: I don't have to load the app that I was using again.

So by insisting on loading different things in the same tab in pursuit of the big single page application feel, we're effectively discouraging users from using the multitasking feature that comes with a web browser.

@nextcloud/designers please go and take a look at other (multi-app) projects, the usual suspects. All of them open apps and global settings in new tabs, despite the fact that their loading times are in general faster than ours. (Testing their loading times vs. my local docker loading times).

[szaimen]

Hm... I think I don't like this idea. New tabs usually should only be opened for links to external services or if it is really necessary IIRC...

[marcoambrosini]

New tabs usually should only be opened for links to external services

That is just a convention that seems to be born out of not wanting users to navigate away from your site. Not a UX rule.

As per the necessity of it, I think here it's warranted because of the reasons I mentioned above. And our friends at G & M, that have all the UX research resources that they want, reached that conclusion too.

[szaimen]

And our friends at G & M, that have all the UX research resources that they want, reached that conclusion too.

Fine by me then 👍

[fitrahmunir]

@nickvergessen please review this PR

[emoral435]

I agree with the designers, I think that not having the user exit out of the page is always convenient. IMO - I would rather use more RAM for the tab than have to navigate back to my page xD But I like the code changes as well, just a minor request

[emoral435]

for here, can we have a default of null? In case the user does not input anything into the component, having the null would make it would not be a breaking change :)