Public shared links refreshing continuously since v28 upgrade #42200

psy0rz · 2023-12-13T10:02:12Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

Demo url: https://cloud.datux.nl/s/qokf5AXDKN2S4E8

It keeps refreshing, nothing to see in the logs and nextcloud.log.

I'm running the official docker images behind a reverse proxy. (nextcloud:fpm-alpine)

Steps to reproduce

Share public link
Try to open it
Browser keeps refreshing.

Expected behavior

should show the shared folder in the browser, without a reload loop.

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

Other

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

{
    "system": {
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.datux.nl"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.0.11",
        "overwrite.cli.url": "https:\/\/cloud.datux.nl",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "overwriteprotocol": "https",
        "overwritehost": "cloud.datux.nl",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 2,
        "maintenance": false,
        "theme": "",
        "app_install_overwrite": [
            "epubreader"
        ]
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - bruteforcesettings: 2.8.0
  - cloud_federation_api: 1.11.0
  - dashboard: 7.8.0
  - dav: 1.29.1
  - federatedfilesharing: 1.18.0
  - files: 2.0.0
  - files_external: 1.20.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - firstrunwizard: 2.17.0
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - notes: 4.9.0
  - notifications: 2.16.0
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - photos: 2.4.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - related_resources: 1.3.0
  - settings: 1.10.0
  - sharebymail: 1.18.0
  - support: 1.11.0
  - suspicious_login: 6.0.0
  - systemtags: 1.18.0
  - text: 3.9.1
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - twofactor_totp: 10.0.0-beta.2
  - updatenotification: 1.18.0
  - user_status: 1.8.1
  - viewer: 2.2.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0
  - circles: 28.0.0-dev (installed 27.0.1)
  - comments: 1.18.0 (installed 1.17.0)
  - contactsinteraction: 1.9.0 (installed 1.8.0)
  - encryption: 2.16.0
  - federation: 1.18.0 (installed 1.17.0)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - nextcloud_announcements: 1.17.0 (installed 1.16.0)
  - recommendations: 2.0.0 (installed 1.6.0)
  - serverinfo: 1.18.0 (installed 1.17.0)
  - survey_client: 1.16.0 (installed 1.15.0)
  - theming_customcss: 1.15.0 (installed 1.15.0)
  - user_ldap: 1.19.0
  - weather_status: 1.8.0 (installed 1.7.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

(empty log, only contained old entries)

Additional info

No response

stemod · 2023-12-13T12:32:52Z

We got the same problems with multiple instances after upgrade.

psy0rz · 2023-12-13T13:57:24Z

vote it up, people! :)

torrentkino · 2023-12-13T14:34:59Z

It does not seem to affect new shared public links but old ones. At least in our case.

torrentkino · 2023-12-13T15:24:01Z

Ah. I figured it out. Sharing files still works. Sharing directories result in this refreshing bug.

x5355 · 2023-12-13T16:35:13Z

I can confirm this bug on Debian Bookworm with Apache and PHP 8.1. I also can confirm that it affects directories shared by link or mail. I had to rollback the affected instance.

peacepenguin · 2023-12-13T21:32:35Z

Same issue here after v28 upgrade. sharing directories, new and old share links of directories. ubuntu 20.04, php 8.1, apache.

peacepenguin · 2023-12-13T22:05:29Z

WORKAROUND FOUND:

Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"

Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

torrentkino · 2023-12-14T07:18:24Z

WORKAROUND FOUND:

Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"

Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

For me, it was the opposite. Enabling this option helped. Hm. Anyway. Thank you!

dkmonaghan · 2023-12-14T08:43:51Z

Same issue, however mine was fixed by enabling "Allow users on this server to send shares to other servers".

vitormfgoncalves · 2023-12-14T16:28:31Z

Same issue, however mine was fixed by enabling "Allow users on this server to send shares to other servers".

Same here. I dont like to leave this option enabled...

OliJue · 2023-12-14T21:19:31Z

Same issue, however mine was fixed by enabling "Allow users on this server to send shares to other servers".

Same here. Fixed by above mentioned workaround.

psy0rz · 2023-12-15T08:43:02Z

WORKAROUND FOUND:

Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"

Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

can confirm that this works.

dorianborovina · 2023-12-15T13:57:18Z

WORKAROUND FOUND:

Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"

Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

I can confirm that upgrade from the v27.1.4 (or which one was it) to v28, killed sharing on both NC instances.

Enabling this option has fixed it on my end! 👍

cmdflow · 2023-12-15T21:40:13Z

I created a new folder and shared it => Browser keeps redirecting not showing anything
Old shares => Browser keeps redirecting, not showing anything

Bug still exists

cmdflow · 2023-12-15T21:42:54Z

WORKAROUND FOUND:
Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"
Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

can confirm that this works.

ENABLING does "solve" the issue and the folder is displayed properly. But without enabling it does not work

joshtrichards · 2023-12-18T20:08:54Z

The underlying cause is documented in #42313 thanks to analysis by @AsamK.

Either need to figure out where the duplicate X-Requested-With is being added or modify the check for it to not look for a single value.

The above (in this thread) mentioned toggling is just a workaround that can work in some environments.

joshtrichards · 2023-12-29T17:03:16Z

Possibly a regression introduced via #39924 or #40951

More reports on the Help Forums too about public shares not working with NC28 like in this issue.

Cc: @nextcloud/files

ownedge13 · 2023-12-31T10:02:29Z

disabling "Administrative Settings" -> "Administration" -> "Sharing" -> "Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)" doesn't work for me, when i access a shared folder it's stuck in a refresh loop, and if i enable it it doesn't loop, but the folder is empty (there is files in it)

the error.log give that when i access a share with the option enable:
2023/12/31 11:08:08 [error] 385#385: *474 open() "/app/www/public/js/core/merged-template-prepend.js" failed (2: No such file or directory), client: ip.ip.ip.ip, server: _, request: "GET /js/core/merged-template-prepend.js?v=009700fe-0 HTTP/1.1", host: "nextcloud.mydomain.com", referrer: "https://nextcloud.mydomain.com/s/ybbiLa9Dn6kjEbF"

nfp0 · 2023-12-31T12:32:08Z

@ownedge13 Hmm, the empty folder part sounds like it might be a different issue than the one discussed here.

ownedge13 · 2023-12-31T13:33:24Z

idk, here videos enable and disable : "Administrative Settings" -> "Administration" -> "Sharing" -> "Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)"

https://drive.google.com/drive/folders/1VTQCKMLvORB7GdPtpD-koxeMV-OOL4ua?usp=drive_link

edit : i was having 2 problems, now with the option enable, it work.

Ducknuke · 2024-01-08T10:26:24Z

Hello everybody,
Since update 28 I have the same problem on my Nextcloud instance (container). Unable to have the side panel (endless refresh).
I notice that nextcloud is looking for files in a folder that does not exist :

[error] 402#402: *197 open() "/app/www/public/js/core/merged-template-prepend.js" failed (2: No such file or directory), client: x.x.x.x, server: domaine.fr, request: "GET /js/core/merged-template-prepend.js?v=9aa19e9a-0 HTTP/1.1", host: "nextcloud.domaine.fr", referrer: "https://nextcloud.domaine.fr/apps/files/"

I noticed that these files were in /data/appdata_ocmx20us7sn3/js/core/.
I also found a "merged-template-prepend.JSON" (not js) in app/www/public/core/js/ so I have a .../core/js/... but not .../js/core/...

So I copied the files from the /data/appdata_ocmx20us7sn3/js/core/ folder to put them in a new folder /app/www/public/js and the shares and the side panel returned...
I don't understand this sudden change of folder path... I hate copying and pasting without really understanding what's happening. Since update in NC28 I have been fighting against all kinds of new problems :(

skjnldsv · 2024-01-16T16:47:16Z

Fix in #42853

joho1968 · 2024-01-17T06:57:07Z

WORKAROUND FOUND:
Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"
Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

We don't have any of that enabled, and we're still seeing the issue(s).

FerencIstvan · 2024-01-17T08:29:47Z

We don't have any of that enabled, and we're still seeing the issue(s).

Toggle this option. In my case, all was off, but when I turned this option on, the issue past.
So I leave it enabled, till the fix (thanks for that) will be available.

b-pfl · 2024-01-22T10:35:15Z

As much as I love Nextcloud and value the hard work that all volunteers (and paid developers) put into NC, I need to admit that I am surprised that such a bug slips through all tests for a final release...

b-pfl · 2024-01-22T23:42:24Z

Fix in #42853

@skjnldsv so does this mean that the workaround mentioned by
@joho1968 (see below) can be revoked once the next update is out? Can you confirm / inform people in this thread once the fix of #42853 is released?

WORKAROUND FOUND:
Disable this setting under "Administrative Settings" -> "Administration" -> "Sharing"
Allow users on this server to send shares to other servers (this option also allows WebDAV access to public shares)

We don't have any of that enabled, and we're still seeing the issue(s).

joshtrichards · 2024-01-23T00:31:36Z

@b-pfl The fix has already been merged into the stable28 code base by way of #42882 (a backport of #42853). It'll be in the final release of v28.0.2.

Can you confirm / inform people in this thread once the fix of #42853 is released?

That's what release notes are for. :)

It's already released in the latest Release Candidate build and listed in the associated RC release notes:

https://help.nextcloud.com/t/rcs-of-28-0-2-27-1-6-and-26-0-11/179353

So probably won't hear any other follow-up here. :-)

oculos · 2024-01-24T13:35:05Z

@joshtrichards Please test the side panel - I realized that after updating the patch above, the activity panel shows "Unable to load activity list"

demlak · 2024-01-24T13:42:51Z

In here, the patch stopped the refreshing..
but i still cant open imagesfiles on a public shared folder..

susnux · 2024-01-24T13:51:40Z

I realized that after updating the patch above, the activity panel shows "Unable to load activity list"

Did you just apply the patch or upgrade to RC3? Because there was a bug like this fixed for activity in RC2 / RC3

oculos · 2024-01-24T13:53:11Z

We just applied the patch.

…

On 24 Jan 2024, at 14:51, Ferdinand Thiessen ***@***.***> wrote: I realized that after updating the patch above, the activity panel shows "Unable to load activity list" Did you just apply the patch or upgrade to RC3? Because there was a bug like this fixed for activity in RC2 / RC3 — Reply to this email directly, view it on GitHub <#42200 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABT2F43U4E4WJBKGIPIB2SLYQEGXZAVCNFSM6AAAAABAS35D22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGE3DINJYGA>. You are receiving this because you commented.

GHBLoos · 2024-03-15T07:51:06Z

App cfg_share_links does not work anymore on NC28. Is this issue related to the issue that's solved here? In other words, is there a bug in NC28 or is it in the app? I hope someone can dive into that.
jimmyl0l3c/cfg_share_links#182

EDIT: This is fixed.

psy0rz added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Dec 13, 2023

szaimen added the 28-feedback label Dec 13, 2023

nullinger mentioned this issue Dec 18, 2023

[Bug]: Public share link not working when OutgoingServer2serverShare is disabled #42313

Closed

8 tasks

joshtrichards added feature: sharing regression labels Dec 18, 2023

joshtrichards added 1. to develop Accepted and waiting to be taken care of feature: files and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 21, 2023

joshtrichards changed the title ~~[Bug]: public shared links keep refreshing since v28 upgrade~~ Public shared links refreshing continuously since v28 upgrade Jan 1, 2024

joshtrichards mentioned this issue Jan 3, 2024

[Bug]: CSP problem in file sharing causes page to refresh #42557

Closed

8 tasks

This comment was marked as off-topic.

Sign in to view

This comment was marked as spam.

Sign in to view

come-nc mentioned this issue Jan 11, 2024

[Bug]: Infinite refresh loop when refreshing an empty folder with sidebar open #42721

Closed

8 tasks

skjnldsv mentioned this issue Jan 16, 2024

fix(dav): ajax request check on public remote endpoints #42853

Merged

skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 16, 2024

skjnldsv self-assigned this Jan 16, 2024

skjnldsv closed this as completed in #42853 Jan 17, 2024

joshtrichards unpinned this issue Jan 23, 2024

joshtrichards pinned this issue Jan 23, 2024

JcMinarro mentioned this issue Jan 25, 2024

[Bug]: Endless loading when open details tab #43049

Closed

8 tasks

ToS0 mentioned this issue Feb 1, 2024

Make compatible witn NC28 jimmyl0l3c/cfg_share_links#182

Closed

AsamK mentioned this issue Feb 3, 2024

[Bug]: Files shared via Public Share Links no longer accessible (HTTP 401) #43287

Closed

8 tasks

Dennis1993 unpinned this issue Feb 21, 2024

This comment was marked as off-topic.

Sign in to view

dvdsnchzIT mentioned this issue Apr 4, 2024

[Bug]: Can't share folders/files from webui, infinite load #44646

Closed

8 tasks

kesselb mentioned this issue Apr 17, 2024

[stable24] fix(dav): ajax request check on public remote endpoints #44895

Merged

6 tasks

Public shared links refreshing continuously since v28 upgrade #42200

Public shared links refreshing continuously since v28 upgrade #42200

Comments

psy0rz commented Dec 13, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

stemod commented Dec 13, 2023

psy0rz commented Dec 13, 2023

torrentkino commented Dec 13, 2023

torrentkino commented Dec 13, 2023

x5355 commented Dec 13, 2023

peacepenguin commented Dec 13, 2023

peacepenguin commented Dec 13, 2023 • edited Loading

torrentkino commented Dec 14, 2023

dkmonaghan commented Dec 14, 2023

vitormfgoncalves commented Dec 14, 2023

OliJue commented Dec 14, 2023

psy0rz commented Dec 15, 2023

dorianborovina commented Dec 15, 2023 • edited Loading

cmdflow commented Dec 15, 2023

cmdflow commented Dec 15, 2023

joshtrichards commented Dec 18, 2023 • edited Loading

joshtrichards commented Dec 29, 2023

ownedge13 commented Dec 31, 2023 • edited Loading

nfp0 commented Dec 31, 2023

ownedge13 commented Dec 31, 2023 • edited Loading

Ducknuke commented Jan 8, 2024

This comment was marked as off-topic.

This comment was marked as spam.

skjnldsv commented Jan 16, 2024

joho1968 commented Jan 17, 2024

FerencIstvan commented Jan 17, 2024

b-pfl commented Jan 22, 2024

b-pfl commented Jan 22, 2024

joshtrichards commented Jan 23, 2024

oculos commented Jan 24, 2024 • edited Loading

demlak commented Jan 24, 2024

susnux commented Jan 24, 2024

oculos commented Jan 24, 2024 via email

GHBLoos commented Mar 15, 2024 • edited Loading

This comment was marked as off-topic.

peacepenguin commented Dec 13, 2023 •

edited

Loading

dorianborovina commented Dec 15, 2023 •

edited

Loading

joshtrichards commented Dec 18, 2023 •

edited

Loading

ownedge13 commented Dec 31, 2023 •

edited

Loading

ownedge13 commented Dec 31, 2023 •

edited

Loading

oculos commented Jan 24, 2024 •

edited

Loading

GHBLoos commented Mar 15, 2024 •

edited

Loading