Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an aadditional "checkmark" / "cross" icon-only button on the right inside the rename input field for files app #44833

Closed
emoral435 opened this issue Apr 15, 2024 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@emoral435
Copy link
Contributor

Feature/Design Issue

Currently, when renaming an file / folder on the files app, there is no button to confirm or reject the current text within the input field.

This issue proposes to add a "check" / "cross" icon so that users can have extra input to be able to confirm their input.

See

image
@emoral435 emoral435 added enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 15, 2024
@emoral435
Copy link
Contributor Author

Just opened (a few minutes before mine xD).

See #44832

@raphj
Copy link

raphj commented Apr 15, 2024

Ah, damned, sorry for the race condition, I should have taken the lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

2 participants