fix(files): apply the renaming when leaving the input field

[raphj]

• Resolves: Validate renaming by clicking outside the name #42689

Summary

With this change, clicking outside during rename behaves as in any other file manager and applies the rename instead of discarding it

TODO

• The Nextcloud team to check that the change is indeed wanted

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[jancborchardt]

Sounds ok to me. Additionally I think we need a simple "checkmark" icon-only button on the right inside the rename input field so people can decidedly confirm via a mouse click and not be confused about how to confirm.

[raphj]

Sounds ok to me. Additionally I think we need a simple "checkmark" icon-only button on the right inside the rename input field so people can decidedly confirm via a mouse click and not be confused about how to confirm.

Yep, and it occurred to me that in the same vein, we may want to have a "cross" icon-only button on the right side inside the rename input field to decidedly cancel the rename. WDYT?

This should be done in a separate PR, right?

[emoral435]

This should be done in a separate PR, right?

Yes, I think that that this should be a separate PR, with its own associated issue :)

As far as this PR goes, I havent tested it locally, but this makes sense to me, and if design team thinks this is a good change, then LGTM!

[raphj]

with its own associated issue :)

See #44832

[emoral435]

aha, seems like I was a bit too late to the draw for the issue xD i'll close mine!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[jancborchardt]

This could use another designer/frontender review for correctness. :)
@marcoambrosini @szaimen

[szaimen]

I think this is fine. Also already got a +1 from a frontender :)

[szaimen]

/compile

[szaimen]

/compile