S3 causes an issue when no hostname is set.

[thelfensdrfer]

server/lib/private/Files/ObjectStore/S3ConnectionTrait.php

Line 74 in 3bb0c9b

$params['s3-accelerate'] = $params['hostname'] == 's3-accelerate.amazonaws.com' || $params['hostname'] == 's3-accelerate.dualstack.amazonaws.com';

But according to the docs, a hostname doesn't have to be set.

Message in the log: Undefined array key "hostname" at /var/www/html/lib/private/Files/ObjectStore/S3ConnectionTrait.php#74

Version: 29.0.1

[kesselb]

I guess we need a isset check.
Mind to send a pull request?

cc @icewind1991 @artonge

[joshtrichards]

Our integration tests didn't catch it I guess because we test against Minio with a hostname set rather than AWS. Don't see a good way to improve the tests at the moment, unless we start running them against AWS directly (which is outside my purview, but wouldn't be too challenging in theory...).

Fix pending in #45649.

Thanks for reporting @thelfensdrfer.

If you are able, appreciate a test of the fix in your environment.

[stszap]

We are on 29.0.1 too and are having the same problem. We can't do a clean install, unfortunately, but I was able to manually patch the file in question the same way as in the PR above and the error messages stopped.