File view: Double click and right click #5

maprambo · 2016-06-04T14:04:30Z

Afaik since ownCloud 8.2 there is a side panel with extra information. Since then, friends of mine had problems opening files and folder in the web interface. In most native file browsers you have to double click to open a file or folder - why not doing this in Nextcloud, too?
Another thing is that all the options for sharing, renaming, downloading and so on should also be accessible via right click.
Both these small changes would improve the navigation and make Nextcloud feel more native.

MariusBluem · 2016-06-04T15:11:11Z

I think that could cause browser or os specific problems. Especially on mobile devices. I don't know whether we should introduce right- or double-click actions and menus 😕

cc @nextcloud/designers

maprambo · 2016-06-04T15:13:13Z

I've thought of that. These users can still use the "three-dot-menu", can't they? I wouldn't remove the current menus.

BernhardPosselt · 2016-06-04T15:38:39Z

Sure you can maintain a mouse and a touch version where in the mouse version everything is delegated to a menu opened by a right click while the touch version has separate buttons.

Turns out maintaining two different interaction models is just very, very cumbersome. It's much easier to find the common ground and make it work well for both platforms.

maprambo · 2016-06-04T15:45:47Z

Wouldn't it be possible to save all menu entries in one database and then specify where every entry should appear?

BernhardPosselt · 2016-06-04T15:50:17Z

No need to save it in the database at all ;)

Building, testing and maintaining the UI while keeping both designs consistent is the real challenge

maprambo · 2016-06-04T19:15:49Z

I just thought of the three-dot-menu to be displayed at the position of the mouse (same css class etc., but with all entries). I'm sorry, I think I'm too dumb to understand the problem here.

jancborchardt · 2016-06-06T21:30:28Z

As @Mar1u5 and @BernhardPosselt already mentioned, there are severe maintenance problems with it.

Apart from that, double-click is used nowhere in browsers and usually is used for marking text, so it will likely lead to issues. Also, neither double-click nor right-click is easily discoverable, so we should not use it.

jancborchardt · 2016-06-06T21:31:25Z

Aah ok so I mean the right-cick thing we might be able to do, displaying the 3-dot-menu at the position of the cursor. @BernhardPosselt @MorrisJobke @Henni do you think this is doable?

BernhardPosselt · 2016-06-06T21:39:49Z

Won't this still break the context menu as in prevent you from copy text?

jancborchardt · 2016-06-06T21:44:13Z

But in the list there’s nothing to copy. If you really want to copy the filename, you can rename and then copy. Marking by dragging is not possible anyway because of drag&drop kicking in.

Bullnados · 2016-10-16T21:46:07Z

Something new here? I think the right click menu replace the standard browser right click menu, I'm right?
Little bit like the Dropbox Web-Interface

jasonbayton · 2016-11-17T10:46:32Z

Adding some activity to this as I'd like to see right-click menus implemented 👍

jancborchardt · 2016-11-17T16:33:33Z

This sounds like a good Javascript starter issue.

Step 1: on right-click of a row, toggle the actions menu
Step 2: show the actions menu at the place of the cursor

@jasonbayton @Bullnados @maprambo please let your programmer friends know of this issue if you want to push development. :) We are an open source project and everyone can contribute.

jancborchardt · 2017-01-19T00:49:04Z

After much deliberation I think it’s best to not even make right-click any part of Nextcloud. For a few simple reasons:

If it works in one place, people expect it to work everywhere.
We have to check a ton of menus to make them show on right-click. 3-dot menus in all different apps etc.
If it doesn’t work somewhere, people will be confused or frustrated.

It’s pretty much impossible to make sure all apps follow suit on this. For the little gain this gives us it’s not worth the risk at all.

# This is the 1st commit message: Patch from PR 24574 to view.js Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#2: Patch from PR 24574 to lib/Connection.php Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#3: Patch from PR 24574 to lib/Wizard.php Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#4: Patch from PR 24574 to lib/LDAP.php (manually) Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#5: Added a function usesLdapi() in Configuration.php and referenced that function throughout the PR Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#6: Removed the questions I added in comments - https://github.com/nextcloud/server/pull/24574/files#r825732903 Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#7: Changed the test as requested - https://github.com/nextcloud/server/pull/24574/files#r825726282 Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#8: Changing return type from bool to int Signed-off-by: Vincent Van Houtte <vvh@aplusv.be> # This is the commit message nextcloud#9: Changing return type of usesLdapi() to bool and adapting references Signed-off-by: Vincent Van Houtte <vvh@aplusv.be>

fixes this error caused when system has usernames that are purely numeric. An unhandled exception has been thrown: Error: Object of class OCA\User_LDAP\User\User could not be converted to string in /var/www/nextcloud/apps/user_ldap/lib/User_LDAP.php:312 Stack trace: #0 [internal function]: OCA\User_LDAP\User_LDAP->userExistsOnLDAP() nextcloud#1 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(126): call_user_func_array() nextcloud#2 /var/www/nextcloud/apps/user_ldap/lib/Proxy.php(140): OCA\User_LDAP\User_Proxy->walkBackends() nextcloud#3 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(262): OCA\User_LDAP\Proxy->handleRequest() nextcloud#4 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(239): OCA\User_LDAP\User_Proxy->userExistsOnLDAP() nextcloud#5 /var/www/nextcloud/lib/private/User/Manager.php(168): OCA\User_LDAP\User_Proxy->userExists() nextcloud#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(399): OC\User\Manager->get() nextcloud#7 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(226): OCA\Files_FullTextSearch\Service\FilesService->initFileSystems() nextcloud#8 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(246): OCA\Files_FullTextSearch\Service\FilesService->getChunksFromUser() nextcloud#9 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(174): OCA\Files_FullTextSearch\Provider\FilesProvider->generateChunks() nextcloud#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(403): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser() nextcloud#11 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(280): OCA\FullTextSearch\Command\Index->indexProvider() nextcloud#12 /var/www/nextcloud/3rdparty/symfony/console/Command/Command.php(298): OCA\FullTextSearch\Command\Index->execute() nextcloud#13 /var/www/nextcloud/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run() nextcloud#14 /var/www/nextcloud/3rdparty/symfony/console/Application.php(1040): OC\Core\Command\Base->run() nextcloud#15 /var/www/nextcloud/3rdparty/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand() nextcloud#16 /var/www/nextcloud/3rdparty/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun() nextcloud#17 /var/www/nextcloud/lib/private/Console/Application.php(206): Symfony\Component\Console\Application->run() nextcloud#18 /var/www/nextcloud/console.php(100): OC\Console\Application->run() nextcloud#19 /var/www/nextcloud/occ(11): require_once('...') nextcloud#20 {main}roopico /var/www/nextcloud/apps/user_ldap/lib/User/OfflineUser.phparch:index Signed-off-by: Alexie Papanicolaou <alpapan@gmail.com>

jancborchardt closed this as completed Jun 6, 2016

jancborchardt reopened this Jun 6, 2016

jancborchardt added enhancement design Design, UI, UX, etc. labels Jun 6, 2016

MorrisJobke mentioned this issue Jun 21, 2016

Right Click Custom Context #182

Closed

nccguru mentioned this issue Jun 22, 2016

Show proper feedback in upload progress bar - seems to hang at 100% #202

Closed

jowi24 mentioned this issue Jul 22, 2016

Upgrade issue 9.0.50 -> 10.0beta: undefined method during federations upgrade #531

Closed

wherf mentioned this issue Oct 19, 2016

Activity notification loop - an email sent to all every 30 minutes #1778

Closed

herrfeuer mentioned this issue Nov 3, 2016

Using user_saml app breaks occ command #1999

Closed

jancborchardt added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix. labels Nov 17, 2016

Putzlappeneimer mentioned this issue Nov 28, 2016

Uploading Files in an Anonymous Upload which is an shared folder #2381

Closed

blizzz mentioned this issue Dec 13, 2016

Offline federated share causes slow down and cannot be removed #2638

Closed

KKyang mentioned this issue Dec 22, 2016

File is lock in Nextcloud 11 with Redis filelocking turned on #2813

Closed

Micha-Btz mentioned this issue Jan 7, 2017

Downloadproblems with 16MBit connection #2974

Closed

alexw1991 mentioned this issue Jan 18, 2017

Old file versions not removed #3145

Closed

corincorvus mentioned this issue May 26, 2022

Doctrine\DBAL\Exception\LockWaitTimeoutException: An exception occurred while executing a query: SQLSTATE[HY000]: General error: 1205 Lock wait timeout exceeded; try restarting transaction #27695

Closed

maxmenGMK mentioned this issue Jun 17, 2022

[Bug]: NC24.0.1 Files and WebDAV doesn't work after update #32609

Closed

8 tasks

alfwro13 mentioned this issue Aug 12, 2022

[Bug]: Upgrade from 24.0.3 to 24.0.4 failed #33520

Closed

9 tasks

atol71 mentioned this issue Aug 30, 2022

Call to a member function getEMailAddress() on null in /var/www/nextcloud/apps/firstrunwizard/lib/Notification/Notifier.php:134 nextcloud/firstrunwizard#735

Closed

9 tasks

sierra2256 mentioned this issue Sep 20, 2022

files:scan" the process stops scanning Files after a Thumbs.db file is hit #33215

Closed

8 tasks

sunflowerbofh mentioned this issue Sep 26, 2022

[Bug]: exception string, boolean expected when sharing with a user #34225

Closed

9 tasks

edwinosky mentioned this issue Oct 4, 2022

[Bug]: not show files s3 primary storage #34407

Closed

9 tasks

Bevito mentioned this issue Oct 12, 2022

[Bug]: Can't delete ldap users #34557

Closed

9 tasks

flaminmoe mentioned this issue Dec 1, 2022

[Bug]: cron issues messages like that roughly 2-3x per day nextcloud/mail#7714

Closed

9 tasks

nowatbuer mentioned this issue Jan 18, 2023

[Bug]: php occ user:delete fails #36222

Closed

9 tasks

informaticavera mentioned this issue Jan 25, 2023

TypeError: Argument 3 passed to OCA\UserStatus\Controller\UserStatusController::__construct() must be of the type string, null given #25071

Closed

soccerdmon11 mentioned this issue Feb 8, 2023

occ files:scan generates an exception for .htaccess file #34334

Open

9 tasks

OneTwoBarbecue mentioned this issue Apr 8, 2023

[Bug]: Unable to delete LDAP-user (remnants) #37632

Closed

9 tasks

AndyXheli mentioned this issue Apr 20, 2023

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

Closed

9 tasks

This was referenced Jun 14, 2023

[Bug]: After upgrading to "27", database indices cannot be upgraded and ONLYOFFICE does not work. #38821

Closed

After upgrading to "27", database indices cannot be upgraded and ONLYOFFICE does not work. ONLYOFFICE/onlyoffice-nextcloud#833

Open

proserver1 mentioned this issue Sep 12, 2023

[Bug]: Error: Interface "OCA\Files_Versions\Versions\INeedSyncVersionBackend" not found #40373

Closed

8 tasks

JRGonz mentioned this issue Jan 17, 2024

[Bug]: After upgrade to 28.0.1 nonstop errors regarding guestName avatar #42858

Closed

8 tasks

nfguide mentioned this issue Feb 7, 2024

[Bug]: enabling external storage on 28.0.2 generates error during occ files:scan #43408

Closed

8 tasks

elr3m mentioned this issue Feb 14, 2024

[Bug]: LDAP migration failing NC27->NC28 involving ldap_group_members table #43584

Closed

8 tasks

d-jsb mentioned this issue Mar 7, 2024

[Bug]: Nummeric user id breaks updatenotifications #44051

Closed

8 tasks

stanke-sk mentioned this issue Mar 11, 2024

[Bug]: Upgrade 27.1.4.1 to 27.1.7.2 to 28.0.3.2 server error #44133

Closed

8 tasks

theyoungstone mentioned this issue Apr 27, 2024

[Bug]: Cron job fails since update to 29.0.0 #45077

Closed

8 tasks

adrhc mentioned this issue Sep 17, 2024

[Bug]: TypeError: substr(): Argument #1 ($string) must be of type string, bool given in nextcloud-29.0.7/lib/private/AppFramework/Http/Request.php:784 #48116

Closed

8 tasks

adhoc-post mentioned this issue Sep 22, 2024

[Bug]: Update to NC30: exception while running setup check #48264

Closed

8 tasks

prasanthcambridge mentioned this issue Oct 17, 2024

[Bug]: LDAP Setup Check Error in Nextcloud Docker Version 30.0.0 #48767

Closed

8 tasks

adrienbricchi mentioned this issue Oct 21, 2024

[Bug]: PostgreSQL : Cronjob fails since the v30 upgrade, on an ARM system, with Feature not supported: 7 ERROR: set-returning functions are not allowed in WHERE #48828

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

File view: Double click and right click #5

File view: Double click and right click #5

maprambo commented Jun 4, 2016

MariusBluem commented Jun 4, 2016

maprambo commented Jun 4, 2016 •

edited

Loading

BernhardPosselt commented Jun 4, 2016

maprambo commented Jun 4, 2016

BernhardPosselt commented Jun 4, 2016

maprambo commented Jun 4, 2016

jancborchardt commented Jun 6, 2016

jancborchardt commented Jun 6, 2016

BernhardPosselt commented Jun 6, 2016

jancborchardt commented Jun 6, 2016

Bullnados commented Oct 16, 2016

jasonbayton commented Nov 17, 2016

jancborchardt commented Nov 17, 2016

jancborchardt commented Jan 19, 2017

File view: Double click and right click #5

File view: Double click and right click #5

Comments

maprambo commented Jun 4, 2016

MariusBluem commented Jun 4, 2016

maprambo commented Jun 4, 2016 • edited Loading

BernhardPosselt commented Jun 4, 2016

maprambo commented Jun 4, 2016

BernhardPosselt commented Jun 4, 2016

maprambo commented Jun 4, 2016

jancborchardt commented Jun 6, 2016

jancborchardt commented Jun 6, 2016

BernhardPosselt commented Jun 6, 2016

jancborchardt commented Jun 6, 2016

Bullnados commented Oct 16, 2016

jasonbayton commented Nov 17, 2016

jancborchardt commented Nov 17, 2016

jancborchardt commented Jan 19, 2017

maprambo commented Jun 4, 2016 •

edited

Loading