Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no file is tagged with a specific tag, that tag should be removed #586

Closed
jancborchardt opened this issue Jul 27, 2016 · 5 comments
Closed
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: tags

Comments

@jancborchardt
Copy link
Member

Currently there can be »empty« tags. Once you typed the tag in the tags field of a file, it will start to exist, even if you remove it from the field directly after.

This is especially annoying for the tags search then where choosing an empty tag just shows the message »No files found for the selected tags«.

As soon as there is no file associated with a tag anymore, the tag is not needed and should be deleted.

@jancborchardt jancborchardt added enhancement 1. to develop Accepted and waiting to be taken care of feature: tags labels Jul 27, 2016
@nickvergessen
Copy link
Member

👎

When you have files_accesscontrol or files_automatedtagging rules depend on such tags they should not be deleted automatically.

Also note, that the tags can be used for other things as well (announcements, whatever).

So automatic deletion is becoming way to complex for live operation. Maybe we could try a repair-step on update, but even then accesscontrol and automatedtagging cases are hard to detect as well as other use-cases of system tags.

@nickvergessen
Copy link
Member

One idea, ask stuff like workflowengine to create tag assignments when a tag is used, so "tag the rule with the tag itself"
Then we might be able to add something like "is the tag assigned to anything" and if not, delete the tag, that might work, but breaks the current behaviour

@MariusBluem
Copy link
Member

owncloud/core#22942

@jancborchardt
Copy link
Member Author

Then we might be able to add something like "is the tag assigned to anything" and if not, delete the tag

Yeah, that’s what I meant. Of course if it’s in use for something, then it should be preserved. But currently you end up with a lot of dead tags.

@MorrisJobke
Copy link
Member

This is part of #1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: tags
Projects
None yet
Development

No branches or pull requests

4 participants