Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The quota button in the user settings table is not aligned vertically #6654

Closed
danxuliu opened this issue Sep 26, 2017 · 13 comments · Fixed by #6669
Closed

The quota button in the user settings table is not aligned vertically #6654

danxuliu opened this issue Sep 26, 2017 · 13 comments · Fixed by #6669
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. low
Milestone

Comments

@danxuliu
Copy link
Member

To see the problem login as the admin and open the Users settings.

Example:
usertable-quota

@nextcloud/designers

@danxuliu danxuliu added design Design, UI, UX, etc. low labels Sep 26, 2017
@danxuliu
Copy link
Member Author

For your information, I noticed that this does not happen in the stable12 branch, so I have made a bisection and found that the issue was introduced in the commit 2e8e6f9; I leave the fixing for the CSS experts ;)

@rullzer
Copy link
Member

rullzer commented Sep 26, 2017

@skjnldsv maybe ;)?

@skjnldsv
Copy link
Member

@rullzer, sneaky sneaky! 😂

@skjnldsv skjnldsv self-assigned this Sep 26, 2017
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Sep 26, 2017
@skjnldsv
Copy link
Member

skjnldsv commented Sep 27, 2017

The progressbar display on the quota button is broken. I can propose something like that instead
capture d ecran_2017-09-27_14-45-54

I did it quickly, needs some adjustments, but overall, what do you think, :)
@jancborchardt @nextcloud/designers

@MorrisJobke
Copy link
Member

I did it quickly, needs some adjustments, but overall, what do you think, :)

Looks good, but the bottom border should be visible and not covered.

@skjnldsv
Copy link
Member

It will need 278241a for the design part though :)

@skjnldsv
Copy link
Member

I'm onto something! Not quite pleased with the result yet! :)
capture d ecran_2017-09-27_15-03-45

@jancborchardt
Copy link
Member

Oh we have a progress bar there? Nice :D looks good @skjnldsv

@skjnldsv
Copy link
Member

That's more like it!! 🚀
@nextcloud/designers, what do you think? @jancborchardt @MorrisJobke ?
capture d ecran_2017-09-27_15-18-15

@MorrisJobke
Copy link
Member

That's more like it!! 🚀
@nextcloud/designers, what do you think? @jancborchardt @MorrisJobke ?

Awesome :)

@skjnldsv
Copy link
Member

Fix is in #6669

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Sep 27, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 27, 2017
@rullzer
Copy link
Member

rullzer commented Sep 28, 2017

@skjnldsv remind me to buy you a beer when we meet in person 🍻 !

@skjnldsv
Copy link
Member

@rullzer no problem!! :p
But why??

@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Sep 28, 2017
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants