Various css fixes

[skjnldsv]

Use filter instead of box-shadow	Better contrast (includes the top arrow)

Implement progress theming (html5)	Also revert text on quota bar and use primary

Rebuilt quota on user list	Fixed some invalid colors too & fix #6654

[codecov-io]

Codecov Report

Merging #6669 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6669      +/-   ##
============================================
- Coverage     53.03%   53.03%   -0.01%     
  Complexity    22583    22583              
============================================
  Files          1417     1417              
  Lines         87866    87873       +7     
  Branches       1341     1341              
============================================
+ Hits          46600    46601       +1     
- Misses        41266    41272       +6

Impacted Files	Coverage Δ	Complexity Δ
apps/files/templates/appnavigation.php	0% <ø> (ø)	0 <0> (ø)	⬇️
core/js/apps.js	50% <0%> (-4.55%)	0 <0> (ø)
settings/templates/users/part.userlist.php	0% <0%> (ø)	0 <0> (ø)	⬇️
...ings/templates/settings/personal/personal.info.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_trashbin/lib/Trashbin.php	72.53% <0%> (+0.24%)	136% <0%> (ø)	⬇️

[MorrisJobke]

Also revert text on quota bar and use primary

The default background of the quota bar should be white instead of grey (like in the files sidebar).

[skjnldsv]

@MorrisJobke This has been requested by @jancborchardt :)

The default background of the quota bar should be white instead of grey (like in the files sidebar).

It's grey in the sidebar! :)

[skjnldsv]

Quota update pushed!
See first post! :)

[skjnldsv]

Okay, let's review @nextcloud/designers
I don't want to make too bigs pr with fixes. I will create new ones if I need!

CC @jancborchardt @MorrisJobke

[jancborchardt]

Wow, looks great, all of it! 👍

[MorrisJobke]

I like ti a lot 👍

[MorrisJobke]

Integration tests fail:

Scenario: log in with invalid user once fixed by admin              # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:32
    Given I act as John                                               # ActorContext::iActAs()
    And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
    When I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I create user unknownUser with password 123456acb             # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user unknownUser    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
      Row for user unknownUser in Users Settings could not be found after 100 seconds (NoSuchElementException)
    And I act as John                                                 # ActorContext::iActAs()
    And I log in with user unknownUser and password 123456acb         # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Files app                 # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

And the upload progress bar is now grey instead of blue.

[skjnldsv]

• fix the upload progress!
• fix tests, need help on this. @danxuliu?

[danxuliu]

I have also noticed a problem when the menu appears over the quota button:

[skjnldsv]

Thank you so much @danxuliu ! :)
Will fix asap!!

• Fix popover to css guidelines!

[jancborchardt]

• @skjnldsv just one detail I noticed: It looks strange that the quota bar (filling) has a border-radius on the top right and bottom right too. It wasn’t there before and looks much better without it. It’s ok for the small progress bars where the tip of the bar is half-round, but on the big quota bar this is strange. :)

[skjnldsv]

Simple idea too, what do you think @jancborchardt @MorrisJobke ?

We could also implement this in the file list when dropping in a folder. Displaying a progressbar on the bottom of the row? :)

Instead of this!

[MorrisJobke]

Simple idea too, what do you think @jancborchardt @MorrisJobke ?

Mmmmh ... I don't like the shadow around the time and the black theme is confusing. I need to see it also in real life to properly judge if it feels right. 😉

[MorrisJobke]

I'm also fine with getting this in now and fix the progress bar design afterwards, if it gets an overhaul anyways. (to not make this even bigger and bigger)

[skjnldsv]

Mmmmh ... I don't like the shadow around the time and the black theme is confusing. I need to see it also in real life to properly judge if it feels right. 😉

Do not judge the colours, the shadow isn't right because I didn't edit it ^^'

@MorrisJobke Completely agree, I won't add the progressbar into this one anyway, was just an idea like this :)
Will push the color fix in a moment!

[skjnldsv]

@MorrisJobke @jancborchardt @danxuliu please review! :)
cc @nextcloud/designers ❤️

[jancborchardt]

@skjnldsv The loong bar on the top is a bit much. Let’s just keep it a short progress bar where you can quickly see the percentage. :) Of course the current bar should be redesigned to use the new thin bar we use for quota too.

Otherwise good! :)

[skjnldsv]

@jancborchardt is it a review? 😆

[jancborchardt]

Yes, my review from earlier still stands :)

[enoch85]

This is great!I really like that someone is paying attention to details.Best regardsDaniel HanssonTech and MeSent from mobile, sorry for typos.Den 28 sep. 2017 17:48 skrev John Molakvoæ <notifications@github.com>:Merged #6669. —You are receiving this because you are on a team that was mentioned.Reply to this email directly, view it on GitHub, or mute the thread.