-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📑 New in apps changelog display #9165
Comments
It should also be visible in the actual place of the app. When a talk update was done, the info should be displayed as soon as the user visits index.php/apps/spreed the first time. Of course this needs to be done by the app itself, I would say we should just provide a frame work how to do this, for displaying something like the first-run-wizzard is something I could imagine. |
The idea, as discssed with @jancborchardt, was to have as little interruption to the user as possible. That's why we did not go for notifications, for instance. Some apps may have not a page of their own (e.g. impersonate, e2ee, checksum), for others a common approach is not really feasible (richdocuments, various viewers). |
As ^ was discussed further on IRC, the takeaways: personally I am not convinced, anyhow opinions on this matter drift to different directions. Imho, we should go with this approach. Later, still something like a reusable Vue component can be offered to display an indicator on an app about news (not a popup). The risk of misuse for unimportant changes is there, but apps could do this already by their own implementations either way. |
A user-facing thing we could do is something in the left #app-navigation. Like a container which can be closed via an x icon in the top right. Similar to what https://github.com shows in the top right when you are logged in (will do a screenshot when they show news again). |
We could also just used the changelog from the app store for that, since the store parses CHANGELOG.md files in the release bundles if they are available.
I would probably break this into two parts, admin related changelog (in the apps management) and a user related changelog as @jancborchardt suggested (in the app itself) |
Interesting aspect. However, sometimes the md file is not present, or worse outdated. The advantage would be that we can show it inline and do not require the user to open another website. The mock would need to be extended to reflect that @jancborchardt
@jancborchardt would be two sorts of "what's new" notification, same discussion for the server part. Especially for later I need a decision sooner than later. Makes sense imho. Your call. |
For sure a good idea to break it into two parts. The first part to implement is the admin side of course. But having it on the user side is also needed further down the line. @blizzz what do you mean by that it needs to be extended to reflect that? Even if a changelog.md is present, I would say we cut it max to the first 3 lines, and encourage people to summarize it in max 3 points (more can be below of course). |
@jancborchardt it's about the link for the changelog, not for the shown 3-line content. The changelog would not to be suited for this. |
So: separate content for end users and for admins. |
@blizzz oh sorry, that was a misunderstanding: By splitting into two parts I meant only the code, not the content. I don’t necessarily think we need separate 3 changelog points for admins and users. That will double the workload of app developers, and I don’t see the reason why the messages should be any different. Admins are users too? |
The thought behind is that for admins it makes sense if some behaviour changed, setting was added, manual operation is necessary, while this is all irrelevant for end users. |
We had a discussion today with @jancborchardt and @MorrisJobke
|
I thought lower right, but in the end it shouldn’t matter that much 😅 |
that's were in most cases the sidebar is, and the first idea was to put it into it. Another question that comes to my mind, what to do with it on mobile view? Not showing at all? Would tend to it, unless, i guess in some places / for some people it might not be so uncommon to operate with mobile devices only. |
It seems that this one will not make it to 14, right? Move to 15? |
Yes, no way to get it done in time, sadly. |
So in the end, is this done? |
This one is for apps - #10050 is the changelog of the server for users. ;) |
Arf, sorry :) |
Good point. Since I am still working on a mockup, i might try to address this point as well if time allows. |
I now created a mockup, first for new Hub releases. Currently under review by the Design team. Will let you know as soon as I have their feedback |
This is implemented already, admins can look at the "changelog" appsidebar tab of the app details. For users apps currently have to provide their own dialog (like talk is doing). |
To add to the current scope, these requirements must be met additionaly:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Unbinding from the feature that was delivered and reopening, as (not-shipped) apps still don't have an option to provide a changelog |
They have. |
Users and admins should have a brief info on what's new in an available app release, and the possibility to have a direct link to a Changelog.
Appeareance on the apps management:
Mockups by @jancborchardt
The text was updated successfully, but these errors were encountered: