Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Nextcloud Hub changelog #1145

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 27, 2024

Current state: Waiting for real data to include.


  • Split code to allow easier addition of new wizard pages
    • Split App.vue into App.vue and SlideShow.vue
    • Add WizardPage as common base for all pages
    • Use script setup to reduce boiler plate code and better TypeScript support
    • Rename pages so the name makes sense
  • Implemented Nextcloud Hub changelog
    • Modified the menu entry from "About" to "About & What's new".
    • Added additional slides to the wizard for changes in the current Nextcloud Hub release and for sharing it with other users.
  • Added dummy data for changelog

@susnux susnux added this to the Nextcloud 29 milestone Mar 27, 2024
@susnux susnux force-pushed the feat/add-nextcloud-changelog branch from c3c6d9a to e76ccb3 Compare April 4, 2024 16:48
@susnux susnux marked this pull request as ready for review April 4, 2024 16:48
@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2024

/backport to stable29

Pytal

This comment was marked as resolved.

@susnux susnux force-pushed the feat/add-nextcloud-changelog branch from 541a278 to d1032fc Compare April 4, 2024 18:02
@susnux susnux requested a review from Pytal April 4, 2024 18:02
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good other than minor remarks, did not test

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><path d="M23.446 18l0.889-5.791h-5.557v-3.758c0-1.584 0.776-3.129 3.265-3.129h2.526v-4.93c0 0-2.292-0.391-4.484-0.391-4.576 0-7.567 2.774-7.567 7.795v4.414h-5.087v5.791h5.087v14h6.26v-14z" fill="currentColor" /></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting an explicit width="32" height="32" may help prevent some visual bugs on svgs

lib/Listener/BeforeTemplateRenderedListener.php Outdated Show resolved Hide resolved
src/components/SlideShow.vue Outdated Show resolved Hide resolved
src/components/pages/HubRelease.vue Outdated Show resolved Hide resolved
src/components/pages/IntroAnimation.vue Outdated Show resolved Hide resolved
axios.delete(generateUrl('/apps/firstrunwizard/wizard'))
}
// Exposes open and close functions from the component
defineExpose({ open, close })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@blizzz blizzz mentioned this pull request Apr 8, 2024
67 tasks
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
* Split `App.vue` into `App.vue` and `SlideShow.vue`
* Add `WizardPage` as common base for all pages
* Use `script setup` to reduce boiler plate code and better TypeScript support
* Rename pages so the name makes sense

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This adds additional slides to the wizard for changes in the current Nextcloud Hub release
and for sharing it with other users.
Also modified the menu entry from "About" to "About & What's new".

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/add-nextcloud-changelog branch from d1032fc to dc4f0ba Compare April 8, 2024 13:03
@susnux susnux modified the milestones: Nextcloud 30, Nextcloud 29 Apr 8, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/add-nextcloud-changelog branch from dc4f0ba to 32f3d46 Compare April 8, 2024 15:47
@susnux susnux merged commit b05e8cf into master Apr 8, 2024
42 checks passed
@susnux susnux deleted the feat/add-nextcloud-changelog branch April 8, 2024 16:11
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📑 New in apps changelog display
4 participants