Replace hard coded HTTP status codes with proper calls to http_response_code #10009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
rullzer,
nickvergessen,
ChristophWurst and
blizzz
| @@ -38,7 +38,7 @@ | |||
| try { | |||
| $dirInfo = \OC\Files\Filesystem::getFileInfo($dir); | |||
| if (!$dirInfo || !$dirInfo->getType() === 'dir') { | |||
| header("HTTP/1.0 404 Not Found"); | |||
| http_response_code(404); | |||
There was a problem hiding this comment.
can we get rid of magic numbers too?
There was a problem hiding this comment.
I assume same reasoning as in #9995 (comment)
There was a problem hiding this comment.
I removed them, because they are either in files that we want to migrate to AppFramework anyway (and use the constants over there) or are in error/exception cases on the top level and can't rely on constants being loadable. Thus I went for the straight number. Also http_response_code + 404 is quite obvious and will also not change that fast.
There was a problem hiding this comment.
okay, makes sense, partly...
We use other OC\ classes before, but I get the point.
blizzz
approved these changes
Jun 27, 2018
MorrisJobke
deleted the
techdebt/noid/replace-headers-with-http_response_code-calls
branch
This was referenced Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9995 and #9996. It also removes the HTTP code constants from
OC_Response.