Make skip navigation links translatable #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
design
jancborchardt
requested review from
MorrisJobke,
tyrylu,
kevgathuku and
skjnldsv
skjnldsv
approved these changes
Jun 27, 2018
MorrisJobke
approved these changes
Jun 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #10019 +/- ##
============================================
+ Coverage 51.97% 51.97% +<.01%
Complexity 26019 26019
============================================
Files 1661 1661
Lines 96177 96175 -2
Branches 1290 1290
============================================
Hits 49986 49986
+ Misses 46191 46189 -2
|
|
Thank you, i wanted to do it, but i did not manage to be fast enough, i was just too much looking into some root cause of pkexec breaking accessibility under Mate. :) |
|
@tyrylu hehe, sorry for taking that from you. ;) But please feel free to fix any other issues, and don't hesitate to ask me for help if you need any. :) (We're also in IRC, freenode network #nextcloud-design, or simply via Riot webchat: https://riot.im/app/#/room/#freenode_#nextcloud-design:matrix.org ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @tyrylu in #10004 (comment) I missed this. :)
Please review @skjnldsv @MorrisJobke @tyrylu @kevgathuku