Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten resource table names to allow install on oracle again #10213

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Shorten resource table names to allow install on oracle again #10213

merged 2 commits into from
Jul 12, 2018

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 12, 2018 •
edited
Loading

@nickvergessen
Shorten resource table names to allow install on oracle again
b7de6d7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jul 12, 2018
georgehrke
georgehrke approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good 👍

@nickvergessen
Also shorten the name of the invitation tokens
daed1be 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Invitation table is also too long

@georgehrke
Copy link
Member

What's the exact limit that oracle enforces?

@MorrisJobke
Copy link
Member

What's the exact limit that oracle enforces?

32 AFAIK, but you need to mind the prefix ;)

MorrisJobke
MorrisJobke approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit 09d5b61 into master Jul 12, 2018
@MorrisJobke MorrisJobke deleted the bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle branch July 12, 2018 10:30
@nickvergessen
Copy link
Member Author

i will write a checker for this

@nickvergessen
Copy link
Member Author

https://travis-ci.org/nextcloud/notifications/builds/403051765 passing with this branch 👍

@nickvergessen nickvergessen mentioned this pull request Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
2. developing Work in progress bug feature: dav feature: install and update high regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @georgehrke @MorrisJobke