Introduces avatars for guest users

[weeman1337]

The main work done here:

• Refactoring of the Avatar class: UserAvatar and GuestAvatar
• The UserAvatar works like the previous Avatar class
• The GuestAvatar creates an avatar image without an user and the functions to store or update the avatar
• For the guests there is an ISimpleFile InMemoryFile that isn't stored. I decided for that way because so the controller part can keep being like it's now and there won't be a mass of guest avatar files over time.
• I saw that ISimpleFile now supports reading/writing via a resource handle. I didn't implement it for the InMemoryFile. I'm not 100% happy with the InMemoryFile. If you have any ideas how to do it without changing all the Avatar interfaces and the file handling through the controller please let me know!
• I didn't introduce caching, because the controller already does it.

Closes #9457

[skjnldsv]

I'm liking this already!! This is how I viewed the global structure of this feature, seems like a nice job!! 🎉

i'll take a look at it tomorrow :)

[mario]

Is it still the same endpoint? How does it work?

[nickvergessen]

Is it still the same endpoint? How does it work?

We will notify you once this is merged and something you can use ;)

[MorrisJobke]

Most likely nothing for 14 -> moving to 15.

@weeman1337 Sorry that this didn't made it into 14, but at some point we need to make a cut.

[jospoortvliet]

To make up for that @weeman1337 any chance we can offer you some beers at the nextcloud conference?

[weeman1337]

Most likely nothing for 14 -> moving to 15

I'm okay with that. I'd like more to see a stable release than having avatars for guests now ;)

any chance we can offer you some beers at the nextcloud conference?

At the same weekend the FrOSCon is happening and I'm helping out there at the FSFE booth. There is a chance I can make it to some of the hackdays...

[jospoortvliet]

At the same weekend the FrOSCon is happening and I'm helping out there at the FSFE booth.

Pretty damn good excuse 👍

There is a chance I can make it to some of the hackdays...

That would 🤘

[ChristophWurst]

@weeman1337 could you take a look at the failing tests? Is this ready for a final review/integration?

[weeman1337]

@ChristophWurst let me do a rebase and then let's see how the tests are doing. Currently the first test thing failes, but I don't get why.. o_O

[kesselb]

[weeman1337]

Thanks @danielkesselberg . Anyway would be cool to see in the test result why it failed..

[ChristophWurst]

Anyway would be cool to see in the test result why it failed..

You can find it at https://drone.nextcloud.com/nextcloud/server/9938/86 (line 87), but I agree that it's hard to locate.

[MorrisJobke]

CI failures are unrelated

[kesselb]

@weeman1337 🏓

[kesselb]

https://drone.nextcloud.com/nextcloud/server/13543/123

[kesselb]

Works 👍 An avatar is returned instead of 404.

[weeman1337]

@danielkesselberg all done ✓

[kesselb]

Mind to have another look? @rullzer @MorrisJobke @nickvergessen @juliushaertl @skjnldsv

[weeman1337]

The guest avatars are now available under the path /avatar/guest/{guestName}/{size}.

[juliusknorr]

One other issue I found is that guest avatars are svg while regular avatars are converted to png. We actually should also provide them as png (since iOS doesn't support svg rendering properly iirc) Also fonts are not properly loaded otherwise when using it outside of Nextcloud:

[weeman1337]

@juliushaertl the guest avatars are now PNGs.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

I pushed a fix for the PHPDoc of the new OCP file. Then this can be merged 👍

Addressed

[MorrisJobke]

I don't like this because it is only needed for the tests :/

[MorrisJobke]

I just pushed a fix for the old composer ClassLoader.php. Thus I will merge this now.