-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User management polishing #10283
User management polishing #10283
Conversation
Regarding the responsiveness of the layout, there are still two small issues, but I cannot figure out how we could address them with the grid layout.
@skjnldsv Maybe you can help me with some grid magic here? |
@juliushaertl @skjnldsv @jancborchardt Do we want to get it in as it is, because it fixes stuff already and fix the remaining this additionally. They do happen on master as well, right @juliushaertl ? |
@MorrisJobke Yes, we can still fix the remaining issues later. |
Could you push the compiled JS file? Then we will review it and merge it. |
Let me do it, because I compiled it anyways 🙈 |
2738dfa
to
ecbbfd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoohoo! 🍻
This one didn't worked, but get this in and do the header font color later. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
6b8a4d0
to
784eef1
Compare
Sorry, hadn't those comments in the tab i had open when I pushed again 🙈 |
Don't worry ;) |
Acceptance tests fail:
|
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Great stuff as always @juliushaertl! :) |
From #10094