Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management polishing #10283

Merged
merged 9 commits into from
Jul 20, 2018
Merged

User management polishing #10283

merged 9 commits into from
Jul 20, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 18, 2018

From #10094

  • "no more results" is not necessary, the whitespace is enough
  • Header labels don't match up with new user input placeholders ("Full name" vs "Display name")
  • Table headers should be lighter font color than the rest of the text
  • "Groups" header doesn't need to be shown when there are no groups
  • Clear button (x) on new user entry not needed, also too dangerous for misclicks to put it next to the confirm button
  • Layout is not responsive at all. Should narrow down column widths
  • Commit updated webpack production build

@juliusknorr juliusknorr added design Design, UI, UX, etc. 2. developing Work in progress papercut Annoying recurring issue with possibly simple fix. labels Jul 18, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Jul 18, 2018
@juliusknorr
Copy link
Member Author

Regarding the responsiveness of the layout, there are still two small issues, but I cannot figure out how we could address them with the grid layout.

  • The last column with actions cannot be forced to a specific width
    image
  • When resizeing the window there is a small area when the grid layout is somehow broken. This happens when resizeing between a width where the scrollbar appears and a width when all columns are shown.
    image

@skjnldsv Maybe you can help me with some grid magic here?

@MorrisJobke
Copy link
Member

@juliushaertl @skjnldsv @jancborchardt Do we want to get it in as it is, because it fixes stuff already and fix the remaining this additionally. They do happen on master as well, right @juliushaertl ?

@juliusknorr
Copy link
Member Author

@MorrisJobke Yes, we can still fix the remaining issues later.

@MorrisJobke
Copy link
Member

Could you push the compiled JS file? Then we will review it and merge it.

@MorrisJobke
Copy link
Member

Could you push the compiled JS file? Then we will review it and merge it.

Let me do it, because I compiled it anyways 🙈

@MorrisJobke MorrisJobke force-pushed the bugfix/10094/user-management branch from 2738dfa to ecbbfd4 Compare July 20, 2018 12:17
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice 👍

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 20, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoohoo! 🍻

@MorrisJobke
Copy link
Member

Table headers should be lighter font color than the rest of the text

This one didn't worked, but get this in and do the header font color later.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 20, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/10094/user-management branch from 6b8a4d0 to 784eef1 Compare July 20, 2018 12:39
@juliusknorr
Copy link
Member Author

Let me do it, because I compiled it anyways

Sorry, hadn't those comments in the tab i had open when I pushed again 🙈

@MorrisJobke
Copy link
Member

Sorry, hadn't those comments in the tab i had open when I pushed again 🙈

Don't worry ;)

@MorrisJobke
Copy link
Member

Acceptance tests fail:

    Then I see that the "Languages" column is shown            # UsersSettingsContext::iSeeThatTheColumnIsShown()
      The Languages column in Users Settings could not be found after 100 seconds (NoSuchElementException)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobke MorrisJobke merged commit 700aafb into master Jul 20, 2018
@MorrisJobke MorrisJobke deleted the bugfix/10094/user-management branch July 20, 2018 15:31
@jancborchardt
Copy link
Member

Great stuff as always @juliushaertl! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants