-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720 #10320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works still totally fine. 👍
@skjnldsv Can you give me a little hint here? How do i fix the missing sign-off's for the older commits? |
@newhinton you'd need to do a |
5bb14f3
to
fd61207
Compare
JSUnit tests fail :/ |
I think i know why, but i'll need some time to fix it |
@newhinton any news? :) |
@skjnldsv I am currently writing exams, and also the heat is very problematic at the moment. I will return developing early next week, though! |
Okay, i'll see if I can help before your return! :) |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
fd61207
to
7a78e0c
Compare
See #9714
See #9720
See #10176
See #10246