Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts the files multi select header width #10331

Merged

Conversation

weeman1337
Copy link
Member

@weeman1337 weeman1337 commented Jul 22, 2018

Just a tiny style adjustment to align the files multi select header.

closes #10330

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 added 3. to review Waiting for reviews feature: files papercut Annoying recurring issue with possibly simple fix. labels Jul 23, 2018
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the proper variable :)
$navigation-width

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337
Copy link
Member Author

@skjnldsv done. I wasn't sure if I can use it, because it's located under core and the other style file is under app/files. So the core variables can be used from any app shipped by default?

@skjnldsv
Copy link
Member

You rocks! :)
Also, now that you're a contributor, you should be able to directly create branches from the nextcloud/server repo ;)

@skjnldsv
Copy link
Member

So the core variables can be used from any app shipped by default?

Any variable used in variables.scss is appended to the compilation of the file, so you're free to use the variables directly yes :)
Note though that we deprecated the use of the scss variables for 15 in favor of css4 variables. So the variables.scss file won't be appended to the scss files anymore in the next version (15)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 262cb04 into nextcloud:master Jul 24, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: files papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files App: Layout issue when selecting multiple files
3 participants