Fix app navigation controller to return an array #10391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to not break compatibility with existing consumers of that endpoint like the apps management or the client Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
added
3. to review
skjnldsv
approved these changes
Jul 25, 2018
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to not break compatibility with existing consumers of that endpoint like the apps management or the client
The NavigationManager->getAll() method was moved to an associative array here: 6f45607#diff-a42705a52a64c13d1977fb3c9e512442L103 That one can't be used since associative arrays are turned to objects when used in JS and the property order is not guaranteed there.
Fixes #10389