Use OC.generateUrl to properly prefix preview images #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
approved these changes
Jul 26, 2018
ChristophWurst
approved these changes
Jul 27, 2018
skjnldsv
added
4. to release
rullzer
approved these changes
Jul 27, 2018
|
I general shouldn't we just fix linkTo? |
|
@rullzer linkTo has a different approach, it looks for the app directory (which may not be /apps/) and uses the correct one to link to a file from there. But maybe we should make that a bit more obvious. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the preview on public share links will not load on setups with use a index.php prefix.
fixes #10414