Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really cleanup the content-wrapper #10421

Merged
merged 5 commits into from
Jul 30, 2018
Merged

Really cleanup the content-wrapper #10421

merged 5 commits into from
Jul 30, 2018

Conversation

skjnldsv
Copy link
Member

After #10363
And #9982

No idea why I left this despite saying I removed it ^^

@skjnldsv
Really cleanup the content-wrapper
88db07d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Jul 27, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jul 27, 2018
@skjnldsv skjnldsv self-assigned this Jul 27, 2018
juliusknorr
juliusknorr approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Yes, let's also get rid of this as well.

skjnldsv added 3 commits July 27, 2018 18:41
@skjnldsv
Height fix for content
09f80df 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
App-content list fixes for new layout
e3d1353 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Mobile fixes and list fixes
3de1eb4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
danxuliu
danxuliu requested changes Jul 30, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit broke the file list layout in the Files app:
content-wrapper-cleanup-file-list

@skjnldsv
Mobile scroll fixes
2be323d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

@danxuliu can you review again please?

@skjnldsv skjnldsv added the bug label Jul 30, 2018
danxuliu
danxuliu approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (in desktop versions of Firefox and Chromium) and works 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2018
@rullzer rullzer merged commit b1af610 into master Jul 30, 2018
@rullzer rullzer deleted the content-wrapper-cleanup branch July 30, 2018 12:01
@MorrisJobke MorrisJobke mentioned this pull request Jul 30, 2018
Closed
51 tasks
@juliusknorr juliusknorr mentioned this pull request Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. enhancement regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @juliusknorr @danxuliu @rullzer